eshell multiple output targets fix

eshell multiple output targets fix

[Bob Halley]

The Eshell documentation says that Eshell can write to multiple output
targets, e.g.

        (+ 1 2) > a > b > c   ; prints number to all three files

When I have tried this, it has not worked; the last redirect target
was the only file written.

Making the following change to esh-io.el fixed things.  Basically the
problem was that the value stored in 'current' was not a list, so the
(and (listp current) (not member where current)) appending logic never
ran.

/Bob


Index: esh-io.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/eshell/esh-io.el,v
retrieving revision 1.6
diff -u -r1.6 esh-io.el
--- esh-io.el	16 Feb 2002 09:42:53 -0000	1.6
+++ esh-io.el	22 Oct 2002 07:47:14 -0000
@@ -396,7 +396,7 @@
 	(if (and (listp current)
 		 (not (member where current)))
 	    (setq current (append current (list where)))
-	  (setq current where))
+	  (setq current (list where)))
 	(if (not (aref eshell-current-handles index))
 	    (aset eshell-current-handles index (cons nil 1)))
 	(setcar (aref eshell-current-handles index) current)))))

Re: eshell multiple output targets fix

[John Wiegley]

>>>>> On Tue Oct 22, Bob writes:

> Making the following change to esh-io.el fixed things.  Basically
> the problem was that the value stored in 'current' was not a list,
> so the (and (listp current) (not member where current)) appending
> logic never ran.

As long as you've tested it with single redirection, piping, and no
redirection, feel free to check it in.  Thanks, Bob!

John

Re: eshell multiple output targets fix

[Bob Halley]

John Wiegley <johnw@gnu.org> writes:

> >>>>> On Tue Oct 22, Bob writes:
> 
> > Making the following change to esh-io.el fixed things.  Basically
> > the problem was that the value stored in 'current' was not a list,
> > so the (and (listp current) (not member where current)) appending
> > logic never ran.
> 
> As long as you've tested it with single redirection, piping, and no
> redirection, feel free to check it in.  Thanks, Bob!

I tested single redirection, multiple redirection, combining redirection
and piping, and no redirections.  All worked.

I am not an official Emacs developer, so I cannot commit the fix. :)

/Bob

Re: eshell multiple output targets fix

[John Wiegley]

>>>>> On Tue Oct 22, Bob writes:

> I am not an official Emacs developer, so I cannot commit the
> fix. :)

Ok, I have checked it in with you as the developer.

John