unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
Cc: emacs-devel@gnu.org
Subject: Re: setq-default docstring fix
Date: Tue, 04 May 2004 21:29:41 +0300	[thread overview]
Message-ID: <87smeg3v1m.fsf@mail.jurta.org> (raw)
In-Reply-To: <jwv4qqww03v.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "04 May 2004 13:53:11 -0400")

Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> The docstring for setq-default mentions an argument named VAR, but it
>> is really named SYMBOL.  Could someone please install this?
>
> I'd rather fix the arglist to use `var'.

The Emacs Lisp reference manual describes it as `symbol'.  But then it
uses `form' instead of `value' for the second argument.  I don't have
an opinion about the name, I only want to point out that it should be
consistently used in all documentation.

BTW, I suggest to change the argument names of `rassq' and `rassoc' too:

Index: emacs/src/fns.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/fns.c,v
retrieving revision 1.362
diff -u -r1.362 fns.c
--- emacs/src/fns.c	26 Apr 2004 21:44:22 -0000	1.362
+++ emacs/src/fns.c	1 May 2004 04:04:32 -0000
@@ -1603,10 +1603,10 @@
 }
 
 DEFUN ("rassq", Frassq, Srassq, 2, 2, 0,
-       doc: /* Return non-nil if KEY is `eq' to the cdr of an element of LIST.
-The value is actually the first element of LIST whose cdr is KEY.  */)
-     (key, list)
-     register Lisp_Object key;
+       doc: /* Return non-nil if VALUE is `eq' to the cdr of an element of LIST.
+The value is actually the first element of LIST whose cdr is VALUE.  */)
+     (value, list)
+     register Lisp_Object value;
      Lisp_Object list;
 {
   Lisp_Object result;
@@ -1615,19 +1615,19 @@
     {
       if (!CONSP (list)
 	  || (CONSP (XCAR (list))
-	      && EQ (XCDR (XCAR (list)), key)))
+	      && EQ (XCDR (XCAR (list)), value)))
 	break;
 
       list = XCDR (list);
       if (!CONSP (list)
 	  || (CONSP (XCAR (list))
-	      && EQ (XCDR (XCAR (list)), key)))
+	      && EQ (XCDR (XCAR (list)), value)))
 	break;
 
       list = XCDR (list);
       if (!CONSP (list)
 	  || (CONSP (XCAR (list))
-	      && EQ (XCDR (XCAR (list)), key)))
+	      && EQ (XCDR (XCAR (list)), value)))
 	break;
 
       list = XCDR (list);
@@ -1645,10 +1645,10 @@
 }
 
 DEFUN ("rassoc", Frassoc, Srassoc, 2, 2, 0,
-       doc: /* Return non-nil if KEY is `equal' to the cdr of an element of LIST.
-The value is actually the first element of LIST whose cdr equals KEY.  */)
-     (key, list)
-     Lisp_Object key, list;
+       doc: /* Return non-nil if VALUE is `equal' to the cdr of an element of LIST.
+The value is actually the first element of LIST whose cdr equals VALUE.  */)
+     (value, list)
+     Lisp_Object value, list;
 {
   Lisp_Object result, cdr;
 
@@ -1657,21 +1657,21 @@
       if (!CONSP (list)
 	  || (CONSP (XCAR (list))
 	      && (cdr = XCDR (XCAR (list)),
-		  EQ (cdr, key) || !NILP (Fequal (cdr, key)))))
+		  EQ (cdr, value) || !NILP (Fequal (cdr, value)))))
 	break;
 
       list = XCDR (list);
       if (!CONSP (list)
 	  || (CONSP (XCAR (list))
 	      && (cdr = XCDR (XCAR (list)),
-		  EQ (cdr, key) || !NILP (Fequal (cdr, key)))))
+		  EQ (cdr, value) || !NILP (Fequal (cdr, value)))))
 	break;
 
       list = XCDR (list);
       if (!CONSP (list)
 	  || (CONSP (XCAR (list))
 	      && (cdr = XCDR (XCAR (list)),
-		  EQ (cdr, key) || !NILP (Fequal (cdr, key)))))
+		  EQ (cdr, value) || !NILP (Fequal (cdr, value)))))
 	break;
 
       list = XCDR (list);

-- 
Juri Linkov
http://www.jurta.org/emacs/

  parent reply	other threads:[~2004-05-04 18:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-04 17:37 setq-default docstring fix Romain Francoise
2004-05-04 17:43 ` Romain Francoise
2004-05-04 17:53 ` Stefan Monnier
2004-05-04 18:06   ` Romain Francoise
2004-05-04 18:29   ` Juri Linkov [this message]
2004-05-05 20:20 ` Richard Stallman
2004-05-05 20:56   ` Romain Francoise

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87smeg3v1m.fsf@mail.jurta.org \
    --to=juri@jurta.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).