From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: setq-default docstring fix Date: Tue, 04 May 2004 21:29:41 +0300 Organization: JURTA Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <87smeg3v1m.fsf@mail.jurta.org> References: <87brl4w0tr.fsf@orebokech.com> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1083695953 16755 80.91.224.253 (4 May 2004 18:39:13 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 4 May 2004 18:39:13 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Tue May 04 20:39:00 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BL4om-0005Js-00 for ; Tue, 04 May 2004 20:39:00 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BL4om-0007Mq-00 for ; Tue, 04 May 2004 20:39:00 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BL4ob-0000nR-Qs for emacs-devel@quimby.gnus.org; Tue, 04 May 2004 14:38:49 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1BL4lb-0007O9-6M for emacs-devel@gnu.org; Tue, 04 May 2004 14:35:43 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1BL4jf-0005fb-Kq for emacs-devel@gnu.org; Tue, 04 May 2004 14:34:14 -0400 Original-Received: from [66.33.219.19] (helo=spoon.dreamhost.com) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BL4je-0005eY-RC for emacs-devel@gnu.org; Tue, 04 May 2004 14:33:42 -0400 Original-Received: from mail.jurta.org (80-235-34-218-dsl.mus.estpak.ee [80.235.34.218]) by spoon.dreamhost.com (Postfix) with ESMTP id 37C2813D8F9; Tue, 4 May 2004 11:33:38 -0700 (PDT) Original-To: Stefan Monnier In-Reply-To: (Stefan Monnier's message of "04 May 2004 13:53:11 -0400") User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:22730 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:22730 Stefan Monnier writes: >> The docstring for setq-default mentions an argument named VAR, but it >> is really named SYMBOL. Could someone please install this? > > I'd rather fix the arglist to use `var'. The Emacs Lisp reference manual describes it as `symbol'. But then it uses `form' instead of `value' for the second argument. I don't have an opinion about the name, I only want to point out that it should be consistently used in all documentation. BTW, I suggest to change the argument names of `rassq' and `rassoc' too: Index: emacs/src/fns.c =================================================================== RCS file: /cvsroot/emacs/emacs/src/fns.c,v retrieving revision 1.362 diff -u -r1.362 fns.c --- emacs/src/fns.c 26 Apr 2004 21:44:22 -0000 1.362 +++ emacs/src/fns.c 1 May 2004 04:04:32 -0000 @@ -1603,10 +1603,10 @@ } DEFUN ("rassq", Frassq, Srassq, 2, 2, 0, - doc: /* Return non-nil if KEY is `eq' to the cdr of an element of LIST. -The value is actually the first element of LIST whose cdr is KEY. */) - (key, list) - register Lisp_Object key; + doc: /* Return non-nil if VALUE is `eq' to the cdr of an element of LIST. +The value is actually the first element of LIST whose cdr is VALUE. */) + (value, list) + register Lisp_Object value; Lisp_Object list; { Lisp_Object result; @@ -1615,19 +1615,19 @@ { if (!CONSP (list) || (CONSP (XCAR (list)) - && EQ (XCDR (XCAR (list)), key))) + && EQ (XCDR (XCAR (list)), value))) break; list = XCDR (list); if (!CONSP (list) || (CONSP (XCAR (list)) - && EQ (XCDR (XCAR (list)), key))) + && EQ (XCDR (XCAR (list)), value))) break; list = XCDR (list); if (!CONSP (list) || (CONSP (XCAR (list)) - && EQ (XCDR (XCAR (list)), key))) + && EQ (XCDR (XCAR (list)), value))) break; list = XCDR (list); @@ -1645,10 +1645,10 @@ } DEFUN ("rassoc", Frassoc, Srassoc, 2, 2, 0, - doc: /* Return non-nil if KEY is `equal' to the cdr of an element of LIST. -The value is actually the first element of LIST whose cdr equals KEY. */) - (key, list) - Lisp_Object key, list; + doc: /* Return non-nil if VALUE is `equal' to the cdr of an element of LIST. +The value is actually the first element of LIST whose cdr equals VALUE. */) + (value, list) + Lisp_Object value, list; { Lisp_Object result, cdr; @@ -1657,21 +1657,21 @@ if (!CONSP (list) || (CONSP (XCAR (list)) && (cdr = XCDR (XCAR (list)), - EQ (cdr, key) || !NILP (Fequal (cdr, key))))) + EQ (cdr, value) || !NILP (Fequal (cdr, value))))) break; list = XCDR (list); if (!CONSP (list) || (CONSP (XCAR (list)) && (cdr = XCDR (XCAR (list)), - EQ (cdr, key) || !NILP (Fequal (cdr, key))))) + EQ (cdr, value) || !NILP (Fequal (cdr, value))))) break; list = XCDR (list); if (!CONSP (list) || (CONSP (XCAR (list)) && (cdr = XCDR (XCAR (list)), - EQ (cdr, key) || !NILP (Fequal (cdr, key))))) + EQ (cdr, value) || !NILP (Fequal (cdr, value))))) break; list = XCDR (list); -- Juri Linkov http://www.jurta.org/emacs/