From: Chong Yidong <cyd@stupidchicken.com>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: allocate_string_data memory corruption
Date: Sat, 28 Jan 2006 23:58:36 -0500 [thread overview]
Message-ID: <87slr7k4ub.fsf@stupidchicken.com> (raw)
In-Reply-To: <E1F2c8e-00017m-Bf@fencepost.gnu.org> (Richard M. Stallman's message of "Fri, 27 Jan 2006 17:32:16 -0500")
"Richard M. Stallman" <rms@gnu.org> writes:
> I don't see any better solution. It is non-trivial to fix the
> behavior of handle_one_xevent with synched input. I, for one, don't
> see any clean way to fix note_mouse_highlight and
> x_handle_dnd_message.
>
> Could you tell us about these problems?
Sure. We already discussed the note_mouse_highlight problem somewhat.
Basically, it can lead to calling realize_face for a mouse face, which
can call allocate_vectorlike and make_uninit_multibyte_string. I
don't know how to avoid this, since the mouse face is constructed on
the fly by merging overlay and text property mouse faces.
As for x_handle_dnd_message, this function has to allocate a vector,
recording the filename "dragged and dropped" into Emacs, that is put
into the arg member of a struct input_event for later processing. We
can't change the arg member from a Lisp_Object to a pointer (and use a
malloc'ed block instead of a vector) because the arg member is used by
other event handlers to pass stuff (e.g., the toolbar handlers). One
solution is to add an additional pointer member to struct input_event,
or make a global variable to store drag and drop events. But I'd
rather not put any more effort into tweaking handle_one_xevent to
avoid allocating Lisp structures. After the release, we can fix
DSYNC_INPUT and make it the default -- DSYNC_INPUT just seems like a
better design.
> Would you please install your patch?
Done.
Can we move forward with the release now? I believe this was the main
bug blocking the process.
next prev parent reply other threads:[~2006-01-29 4:58 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-18 16:57 allocate_string_data memory corruption Chong Yidong
2006-01-18 20:48 ` Stefan Monnier
2006-01-20 0:45 ` Chong Yidong
2006-01-20 1:14 ` Richard M. Stallman
2006-01-20 3:48 ` Stefan Monnier
2006-01-23 20:21 ` Stefan Monnier
2006-01-24 17:23 ` Chong Yidong
2006-01-18 21:35 ` Ken Raeburn
2006-01-18 23:56 ` Chong Yidong
2006-01-19 8:53 ` Romain Francoise
2006-01-19 20:57 ` Stefan Monnier
2006-01-19 22:48 ` Kim F. Storm
2006-01-20 3:46 ` Stefan Monnier
2006-01-20 22:58 ` Richard M. Stallman
2006-01-25 3:26 ` Chong Yidong
2006-01-25 15:45 ` Richard M. Stallman
2006-01-20 1:14 ` Richard M. Stallman
2006-01-20 9:28 ` Ken Raeburn
2006-01-20 22:58 ` Richard M. Stallman
2006-01-18 22:06 ` Eli Zaretskii
2006-01-18 23:48 ` David Kastrup
2006-01-18 23:48 ` Chong Yidong
2006-01-19 1:15 ` Stefan Monnier
2006-01-19 3:21 ` Ken Raeburn
2006-01-19 4:36 ` Eli Zaretskii
2006-01-20 1:14 ` Richard M. Stallman
2006-01-20 3:56 ` Stefan Monnier
2006-01-20 14:49 ` Chong Yidong
2006-01-21 19:57 ` Richard M. Stallman
2006-01-22 17:37 ` Stefan Monnier
2006-01-20 22:58 ` Richard M. Stallman
2006-01-21 4:48 ` Stefan Monnier
2006-01-21 17:31 ` Chong Yidong
2006-01-22 3:57 ` Richard M. Stallman
2006-01-22 16:45 ` Stefan Monnier
2006-01-22 20:06 ` Andreas Schwab
2006-01-23 0:10 ` Richard M. Stallman
2006-01-23 0:35 ` Ken Raeburn
2006-01-23 1:58 ` Stefan Monnier
2006-01-23 2:06 ` Stefan Monnier
2006-01-24 16:46 ` Richard M. Stallman
2006-01-23 0:55 ` Stefan Monnier
2006-01-24 16:46 ` Richard M. Stallman
2006-01-24 17:57 ` Kim F. Storm
2006-01-24 18:33 ` Chong Yidong
2006-01-25 15:45 ` Richard M. Stallman
2006-01-26 1:41 ` Chong Yidong
2006-01-26 17:46 ` Richard M. Stallman
2006-01-26 18:40 ` Stefan Monnier
2006-01-26 19:45 ` Chong Yidong
2006-01-27 22:32 ` Richard M. Stallman
2006-01-27 23:33 ` Stefan Monnier
2006-01-29 14:53 ` Chong Yidong
2006-01-29 4:58 ` Chong Yidong [this message]
2006-01-30 0:57 ` Richard M. Stallman
2006-01-30 1:06 ` Chong Yidong
2006-01-27 22:32 ` Richard M. Stallman
2006-01-26 19:10 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87slr7k4ub.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).