* New 'feature/native-comp' configure flag
@ 2021-02-26 19:43 Andrea Corallo via Emacs development discussions.
2021-02-26 19:57 ` Pip Cet
0 siblings, 1 reply; 5+ messages in thread
From: Andrea Corallo via Emacs development discussions. @ 2021-02-26 19:43 UTC (permalink / raw)
To: emacs-devel
Hi all,
this is just to mention that as part of the code review process was
decided to change the configure flag used to configure the native
compiler in the 'feature/native-comp' branch.
As of 42fc752a14 the new configure flag to activate the Elisp native
compilation is '--with-native-compilation'.
Regards
Andrea
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: New 'feature/native-comp' configure flag
2021-02-26 19:43 New 'feature/native-comp' configure flag Andrea Corallo via Emacs development discussions.
@ 2021-02-26 19:57 ` Pip Cet
2021-02-26 20:17 ` Doug Davis
2021-02-26 20:17 ` Eli Zaretskii
0 siblings, 2 replies; 5+ messages in thread
From: Pip Cet @ 2021-02-26 19:57 UTC (permalink / raw)
To: Andrea Corallo; +Cc: emacs-devel
On Fri, Feb 26, 2021 at 7:44 PM Andrea Corallo via Emacs development
discussions. <emacs-devel@gnu.org> wrote:
> As of 42fc752a14 the new configure flag to activate the Elisp native
> compilation is '--with-native-compilation'.
I still think we should adhere to the GNU Coding Standards
(https://www.gnu.org/prep/standards/standards.html) in this case and
use --enable- here (native compilation is a feature), not --with-
(there is no external package called "native-compilation" that we
somehow depend on).
Pip
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: New 'feature/native-comp' configure flag
2021-02-26 19:57 ` Pip Cet
@ 2021-02-26 20:17 ` Doug Davis
2021-02-26 20:17 ` Eli Zaretskii
1 sibling, 0 replies; 5+ messages in thread
From: Doug Davis @ 2021-02-26 20:17 UTC (permalink / raw)
To: Pip Cet; +Cc: emacs-devel, Andrea Corallo
Pip Cet <pipcet@gmail.com> writes:
> On Fri, Feb 26, 2021 at 7:44 PM Andrea Corallo via Emacs development
> discussions. <emacs-devel@gnu.org> wrote:
>> As of 42fc752a14 the new configure flag to activate the Elisp native
>> compilation is '--with-native-compilation'.
>
> I still think we should adhere to the GNU Coding Standards
> (https://www.gnu.org/prep/standards/standards.html) in this case and
> use --enable- here (native compilation is a feature), not --with-
> (there is no external package called "native-compilation" that we
> somehow depend on).
>
libgccjit is an external package the same way libjansson is an external
package (at least right now I don't know of a GNU/Linux distribution
that ships libgccjit with their gcc package. I could be wrong). So the
similarity of
--with-json requiring libjansson (not some package called json)
and
--with-native-comp requiring libgccjit
does make sense to me. Just my 2c.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: New 'feature/native-comp' configure flag
2021-02-26 19:57 ` Pip Cet
2021-02-26 20:17 ` Doug Davis
@ 2021-02-26 20:17 ` Eli Zaretskii
2021-02-26 20:30 ` Andreas Schwab
1 sibling, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2021-02-26 20:17 UTC (permalink / raw)
To: Pip Cet; +Cc: emacs-devel, akrl
> From: Pip Cet <pipcet@gmail.com>
> Date: Fri, 26 Feb 2021 19:57:06 +0000
> Cc: emacs-devel@gnu.org
>
> On Fri, Feb 26, 2021 at 7:44 PM Andrea Corallo via Emacs development
> discussions. <emacs-devel@gnu.org> wrote:
> > As of 42fc752a14 the new configure flag to activate the Elisp native
> > compilation is '--with-native-compilation'.
>
> I still think we should adhere to the GNU Coding Standards
> (https://www.gnu.org/prep/standards/standards.html) in this case and
> use --enable- here (native compilation is a feature), not --with-
> (there is no external package called "native-compilation" that we
> somehow depend on).
The --with-SOMETHING options are not only for external packages. We
have other similar configure-time options:
--with-modules
--with-threads
--with-native-image-api
--with-dumping
--with-wide-int
etc.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: New 'feature/native-comp' configure flag
2021-02-26 20:17 ` Eli Zaretskii
@ 2021-02-26 20:30 ` Andreas Schwab
0 siblings, 0 replies; 5+ messages in thread
From: Andreas Schwab @ 2021-02-26 20:30 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: akrl, Pip Cet, emacs-devel
On Feb 26 2021, Eli Zaretskii wrote:
> The --with-SOMETHING options are not only for external packages. We
> have other similar configure-time options:
>
> --with-modules
> --with-threads
> --with-native-image-api
> --with-dumping
> --with-wide-int
All those arguably should be --enable, though.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-02-26 20:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-26 19:43 New 'feature/native-comp' configure flag Andrea Corallo via Emacs development discussions.
2021-02-26 19:57 ` Pip Cet
2021-02-26 20:17 ` Doug Davis
2021-02-26 20:17 ` Eli Zaretskii
2021-02-26 20:30 ` Andreas Schwab
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).