* Re: master 5bba1b95b80: Further adjustments for restoring killed buffer windows (Bug#68235)
[not found] ` <20240315093640.D6552C1FB4C@vcs2.savannah.gnu.org>
@ 2024-03-16 1:50 ` Michael Heerdegen
2024-03-16 9:57 ` martin rudalics
0 siblings, 1 reply; 3+ messages in thread
From: Michael Heerdegen @ 2024-03-16 1:50 UTC (permalink / raw)
To: emacs-devel; +Cc: Martin Rudalics
Martin Rudalics via Mailing list for Emacs changes <emacs-diffs@gnu.org>
writes:
> +If the value of this variable is a function, that function should take
> +three arguments. The first argument specifies the frame whose windows
> +have been restored. The third argument is either the constant
> +@code{configuration} if the windows are restored by
> +@code{set-window-configuration} or the constant @code{state} if the
> +windows are restored by @code{window-state-put}.
Martin, can we maybe say "symbol" instead of "constant" here? "Symbol"
is more precise, "constant" is, well, any passed value is constant,
and here the symbol's name is "configuration" which could even mean
"window configuration", so the interpretation of the text is ambiguous.
TIA,
Michael.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 5bba1b95b80: Further adjustments for restoring killed buffer windows (Bug#68235)
2024-03-16 1:50 ` master 5bba1b95b80: Further adjustments for restoring killed buffer windows (Bug#68235) Michael Heerdegen
@ 2024-03-16 9:57 ` martin rudalics
2024-03-17 9:07 ` Michael Heerdegen
0 siblings, 1 reply; 3+ messages in thread
From: martin rudalics @ 2024-03-16 9:57 UTC (permalink / raw)
To: Michael Heerdegen, emacs-devel
> Martin, can we maybe say "symbol" instead of "constant" here? "Symbol"
> is more precise, "constant" is, well, any passed value is constant,
> and here the symbol's name is "configuration" which could even mean
> "window configuration", so the interpretation of the text is ambiguous.
Should be fixed now.
Thanks for checking, martin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 5bba1b95b80: Further adjustments for restoring killed buffer windows (Bug#68235)
2024-03-16 9:57 ` martin rudalics
@ 2024-03-17 9:07 ` Michael Heerdegen
0 siblings, 0 replies; 3+ messages in thread
From: Michael Heerdegen @ 2024-03-17 9:07 UTC (permalink / raw)
To: martin rudalics; +Cc: emacs-devel
martin rudalics <rudalics@gmx.at> writes:
> Should be fixed now.
LGTM, thank you very much.
Michael.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-17 9:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <171049540037.3477.8428413468039226620@vcs2.savannah.gnu.org>
[not found] ` <20240315093640.D6552C1FB4C@vcs2.savannah.gnu.org>
2024-03-16 1:50 ` master 5bba1b95b80: Further adjustments for restoring killed buffer windows (Bug#68235) Michael Heerdegen
2024-03-16 9:57 ` martin rudalics
2024-03-17 9:07 ` Michael Heerdegen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).