Patch: Convenience function for changing font family

Patch: Convenience function for changing font family

[Anand Tamariya]

[-- Attachment #1: Type: text/plain, Size: 1433 bytes --]

Here's a patch for changing the font family on the fly. It's similar to
changing font weight using the keyboard.


diff --git a/lisp/facemenu.el b/lisp/facemenu.el
index b10d874b21..3342b1d4a1 100644
--- a/lisp/facemenu.el
+++ b/lisp/facemenu.el
@@ -103,7 +103,8 @@ facemenu-keybindings
   '((default     . "d")
     (bold        . "b")
     (italic      . "i")
-    (bold-italic . "l") ; {bold} intersect {italic} = {l}
+    (bold-italic . "l") ; {bold} intersect {italic} = {l}/
+    (family      . "f")
     (underline   . "u")))
   "Alist of interesting faces and keybindings.
 Each element is itself a list: the car is the name of the face,
@@ -339,6 +340,16 @@ facemenu-set-face
   (facemenu-add-new-face face)
   (facemenu-add-face face start end))

+(defun facemenu-set-family (family &optional start end)
+  (interactive (list (progn
+                      (barf-if-buffer-read-only)
+                      (completing-read "Font family: " (font-family-list)))
+                    (if (and mark-active (not current-prefix-arg))
+                        (region-beginning))
+                    (if (and mark-active (not current-prefix-arg))
+                        (region-end))))
+  (add-text-properties start end `(face (:family ,family))))
+
 (defun facemenu-set-foreground (color &optional start end)
   "Set the foreground COLOR of the region or next character typed.
 This command reads the color in the minibuffer.

[-- Attachment #2: Type: text/html, Size: 1834 bytes --]

Re: Patch: Convenience function for changing font family

[Andreas Schwab]

On Aug 06 2021, Anand Tamariya wrote:

> diff --git a/lisp/facemenu.el b/lisp/facemenu.el
> index b10d874b21..3342b1d4a1 100644
> --- a/lisp/facemenu.el
> +++ b/lisp/facemenu.el
> @@ -103,7 +103,8 @@ facemenu-keybindings
>    '((default     . "d")
>      (bold        . "b")
>      (italic      . "i")
> -    (bold-italic . "l") ; {bold} intersect {italic} = {l}
> +    (bold-italic . "l") ; {bold} intersect {italic} = {l}/

Spurious change.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

Re: Patch: Convenience function for changing font family

[Eli Zaretskii]

> From: Anand Tamariya <atamariya@gmail.com>
> Date: Fri, 6 Aug 2021 14:33:48 +0530
> 
> Here's a patch for changing the font family on the fly. It's similar to
> changing font weight using the keyboard.

Thanks, but how is this supposed to work?  After applying the patch
and loading facemenu, "M-x facemenu-set-family RET" does nothing, not
even prompts for the font family; and clicking

 Edit->Text Properties->Face->family

from the menu bar just shows "menu-bar edit Text Properties fc f" in
the echo area.

I think one problem is that the facemenu machinery, as you use it,
expects "family" to be a face, and there's no such face.

Did you test this with Emacs 28 from the master branch?  Or what am I
missing?

P.S. Please also provide a doc string for the new function(s), and add
a :version tag to any defcustom you add or change.

Re: Patch: Convenience function for changing font family

[Anand Tamariya]

[-- Attachment #1: Type: text/plain, Size: 1359 bytes --]

On Sun, Aug 8, 2021 at 12:02 PM Eli Zaretskii <eliz@gnu.org> wrote:

> > From: Anand Tamariya <atamariya@gmail.com>
> > Date: Fri, 6 Aug 2021 14:33:48 +0530
> >
> > Here's a patch for changing the font family on the fly. It's similar to
> > changing font weight using the keyboard.
>
> Thanks, but how is this supposed to work?  After applying the patch
> and loading facemenu, "M-x facemenu-set-family RET" does nothing, not
> even prompts for the font family; and clicking
>
>  Edit->Text Properties->Face->family
>
> from the menu bar just shows "menu-bar edit Text Properties fc f" in
> the echo area.
>
> I think one problem is that the facemenu machinery, as you use it,
> expects "family" to be a face, and there's no such face.
>
> Did you test this with Emacs 28 from the master branch?  Or what am I
> missing?
>
> P.S. Please also provide a doc string for the new function(s), and add
> a :version tag to any defcustom you add or change.
>
You are right. I don't understand the face menu system well. It worked for
me because I was evaluating the changes in a running instance. Once I start
a new instance, I can't seem to get it working without re-evaluating
'facemenu-keybindings' followed by (facemenu-update). Also, it's only
supposed to work on a selection of text, i.e. you select some text and then
change the font family for the selection.

[-- Attachment #2: Type: text/html, Size: 1906 bytes --]