unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu <luangruo@yahoo.com>
To: emacs-devel@gnu.org
Subject: browse-url-interactive-arg calls `mouse-set-point' too eagerly
Date: Sat, 20 Nov 2021 14:29:49 +0800	[thread overview]
Message-ID: <87r1bbqqzm.fsf@yahoo.com> (raw)
In-Reply-To: 87r1bbqqzm.fsf.ref@yahoo.com

Selecting "Browse URL" from the xwidget-webkit menu bar results in the
following error:

  signal(error ("Position not in text area of window"))
  error("Position not in text area of window")
  posn-set-point(nil)
  mouse-set-point((menu-bar))
  browse-url-interactive-arg("xwidget-webkit URL: ")
  byte-code("\300\301!\210\302\303!\207" [require browse-url browse-url-interactive-arg "xwidget-webkit URL: "] 2)
  call-interactively(xwidget-webkit-browse-url nil nil)
  command-execute(xwidget-webkit-browse-url)

The doc string of browse-url-interactive-arg says:

  If invoked with a mouse button, it moves point to the position clicked
  before acting.

But the code treats any event that is a list as a mouse event, which
fails horribly with menu bar events.

So why not replace the faulty code with something like:

  (let ((event (elt (this-command-keys) 0)))
    (when (mouse-event-p event)
      (mouse-set-point event)))

WDYT?



       reply	other threads:[~2021-11-20  6:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87r1bbqqzm.fsf.ref@yahoo.com>
2021-11-20  6:29 ` Po Lu [this message]
2021-11-20  7:31   ` browse-url-interactive-arg calls `mouse-set-point' too eagerly Eli Zaretskii
2021-11-20  7:59     ` Po Lu
2021-11-20  8:34       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1bbqqzm.fsf@yahoo.com \
    --to=luangruo@yahoo.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).