From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: browse-url-interactive-arg calls `mouse-set-point' too eagerly Date: Sat, 20 Nov 2021 14:29:49 +0800 Message-ID: <87r1bbqqzm.fsf@yahoo.com> References: <87r1bbqqzm.fsf.ref@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33405"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 20 07:31:56 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1moJum-0008YS-2h for ged-emacs-devel@m.gmane-mx.org; Sat, 20 Nov 2021 07:31:56 +0100 Original-Received: from localhost ([::1]:36356 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1moJuk-00028j-Fx for ged-emacs-devel@m.gmane-mx.org; Sat, 20 Nov 2021 01:31:54 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52520) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moJt2-0001OA-EN for emacs-devel@gnu.org; Sat, 20 Nov 2021 01:30:10 -0500 Original-Received: from sonic314-22.consmr.mail.ne1.yahoo.com ([66.163.189.148]:40772) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1moJt0-0005G8-UV for emacs-devel@gnu.org; Sat, 20 Nov 2021 01:30:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1637389804; bh=x+T3xkqPjes66txW0EZhD7VIX2Cru5m0Lwave4fb0bE=; h=From:To:Subject:Date:References:From:Subject:Reply-To; b=T4limkb4Exnh6XSbNT5KgEeq0QgGg7DG7V2d9wziLAO0d3HEP7inkw9UOYtSuJlPMIXRGE50LntsLWHmYUkIX2G8zCbfGGL9C9pGVFozNZFuf1YPHNmfIUcwytAAn3MJo7AJUZjjpQ3cpxm4WWabn84mCImSHwPsooKqa3Q74lV9UwycwEbSNJuEgemG0H+pCiA5xKRWXUSL7QwqWPAj7Y51MHn5sorzK9GLVlbGi7RHia/fQ448rmlFBbmjyl8ckBgcGKRTjRtNQ0gtDtA23MENlE17Dn3y+Na5mfKZTLqXmmtLc9aZOYBW/1JA46IuL1l6gPMis9hnFWJ2ohC3SA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1637389804; bh=M7VRrcz+6l2bMYBZoDDjn+AZ81HTxKGDm1T4tEsEXJB=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=IIu0e4iGBqV6N0/mmG0bG5R5DHcwoh2kqt3OI813mVbmkDYFwikqFU+3ccuXELP0jqRW56he4BsO0Msxy0kuSiEgqDv0Rud4e8pP25BzfdO1FmsrTAMxfTInlt9beZA84sPtgvdH2FEfcoU3ZqbO8gBu52CvuLb3hgAigghczzz5YFZhS3IiGdgmDTK+cUFmtzFqKA5dHb8OfEWVXCdn/PXIasnupxsDTk9rIWsk4P/I97HWpTA0a2rxEEooHQnZF/QI/xygJHqz4FeCDLB4T8YnUb5cqkwC3PG3Q9tFncQxNrEQIoHmZmLUgYeWXVFnAKnsHACOtJ3qmVU7eau87g== X-YMail-OSG: GEnqfQ0VM1m7tluzf8U0JNM6vRQSuYl.GZvpK.tEzX2ad.VVd3WCnGudf.ine1R ihmtwzufejp2blFl6idlqldnz8GZV5D2p0_Xbz2BnM_RIRI8lZg7xS.cie9N_C9JvRDaNi0NC.3n xPBcePcEDHHQnJ3ZiGKL33Cp3mlhZoDnlPAfEl8cbN7Zzg19VqVKq6Blw74BznoEg5CZziy3K0Rl UMAuh2HXp6UWMesybxcgXUw_KA9ZaSFbt7mc1R.5Bh1H9.V9HRZMbYRRbn0.Luwz8JWOTwhml3wA i6GaGVNyqGAbNpgKGQu6Js_mKnaA0p8VlK0Gpeoh4eHqcqc7xPN2g4s8ZtETCBhlPAnMM9W630Fr zboQ6IotTjDQiNVF937SBxtc7MlBLdckhpvVR44kRxXN1waHY5UWYJzOl2jqcY5SMuHZHlBrGt.S xkny8yHm5a5SzIteP1Hp0kJdzQOvYyP56teHxn.F0V7ReWplMDRMR_y03bd87spdUz8SvJKW6OXu uebuz87idnCCc_YBjP8l_eiLSB4_J5EWJn_vAE83NFpiIl487qNtEpTcacB.dAn9oj7IwAzV5tUl VtriMrckPnLf5lDJLehY4IIQfZQxXnyICzukafR8aqS4jEx7xmj57jQ1MZ0khmOg_Rf62kxLZFLS cFCQWqmIeiV6TqSbyGlkjs4Yo.p5AEdu6iKPnmWPjLt5mdHHCCAi0KrouSAUih1_abmprgzzGwQg 5WNRJ1N16Q.Cx4A9BUBEWsOalnvLyHiz_A7fYIOEKAVNTg8c03nfblCSdgvSa73nxlYDNdaKnAny 3I3DwfMJeHeNZfzYsh1hhhI7ahZ_W2w6kLxlKUP96j X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.ne1.yahoo.com with HTTP; Sat, 20 Nov 2021 06:30:04 +0000 Original-Received: by kubenode513.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 161588b0488104c6b378b03639f23532; Sat, 20 Nov 2021 06:29:57 +0000 (UTC) X-Mailer: WebService/1.1.19306 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.189.148; envelope-from=luangruo@yahoo.com; helo=sonic314-22.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:279783 Archived-At: Selecting "Browse URL" from the xwidget-webkit menu bar results in the following error: signal(error ("Position not in text area of window")) error("Position not in text area of window") posn-set-point(nil) mouse-set-point((menu-bar)) browse-url-interactive-arg("xwidget-webkit URL: ") byte-code("\300\301!\210\302\303!\207" [require browse-url browse-url-interactive-arg "xwidget-webkit URL: "] 2) call-interactively(xwidget-webkit-browse-url nil nil) command-execute(xwidget-webkit-browse-url) The doc string of browse-url-interactive-arg says: If invoked with a mouse button, it moves point to the position clicked before acting. But the code treats any event that is a list as a mouse event, which fails horribly with menu bar events. So why not replace the faulty code with something like: (let ((event (elt (this-command-keys) 0))) (when (mouse-event-p event) (mouse-set-point event))) WDYT?