unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master 8e0b043f49: * src/xterm.c (x_update_opaque_region): Avoid crash at startup in Lucid build
       [not found] ` <20220212224730.AE7C3C00891@vcs2.savannah.gnu.org>
@ 2022-02-13  0:36   ` Po Lu
  2022-02-13  0:47     ` Po Lu
  0 siblings, 1 reply; 4+ messages in thread
From: Po Lu @ 2022-02-13  0:36 UTC (permalink / raw)
  To: emacs-devel; +Cc: Stefan Monnier

Stefan Monnier via Mailing list for Emacs changes <emacs-diffs@gnu.org>
writes:

> branch: master
> commit 8e0b043f49a014d1e3f45bd82917c31aa4181951
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
>     * src/xterm.c (x_update_opaque_region): Avoid crash at startup in Lucid build

The actual fix is to find where x_update_opaque_region is being called
with a NULL frame, since that shouldn't be possible.

It doesn't crash here, FWIW.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: master 8e0b043f49: * src/xterm.c (x_update_opaque_region): Avoid crash at startup in Lucid build
  2022-02-13  0:36   ` master 8e0b043f49: * src/xterm.c (x_update_opaque_region): Avoid crash at startup in Lucid build Po Lu
@ 2022-02-13  0:47     ` Po Lu
  2022-02-13 14:47       ` Stefan Monnier
  0 siblings, 1 reply; 4+ messages in thread
From: Po Lu @ 2022-02-13  0:47 UTC (permalink / raw)
  To: emacs-devel; +Cc: Stefan Monnier

Po Lu <luangruo@yahoo.com> writes:

> Stefan Monnier via Mailing list for Emacs changes <emacs-diffs@gnu.org>
> writes:
>
>> branch: master
>> commit 8e0b043f49a014d1e3f45bd82917c31aa4181951
>> Author: Stefan Monnier <monnier@iro.umontreal.ca>
>> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>>
>>     * src/xterm.c (x_update_opaque_region): Avoid crash at startup in Lucid build
>
> The actual fix is to find where x_update_opaque_region is being called
> with a NULL frame, since that shouldn't be possible.
>
> It doesn't crash here, FWIW.

I might've found it, so please test whether or not the crash is fixed
for you.

Thanks.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: master 8e0b043f49: * src/xterm.c (x_update_opaque_region): Avoid crash at startup in Lucid build
  2022-02-13  0:47     ` Po Lu
@ 2022-02-13 14:47       ` Stefan Monnier
  2022-02-14  0:58         ` Po Lu
  0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2022-02-13 14:47 UTC (permalink / raw)
  To: Po Lu; +Cc: emacs-devel

> I might've found it, so please test whether or not the crash is fixed
> for you.

Yup, still works fine here, thanks,


        Stefan




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: master 8e0b043f49: * src/xterm.c (x_update_opaque_region): Avoid crash at startup in Lucid build
  2022-02-13 14:47       ` Stefan Monnier
@ 2022-02-14  0:58         ` Po Lu
  0 siblings, 0 replies; 4+ messages in thread
From: Po Lu @ 2022-02-14  0:58 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> I might've found it, so please test whether or not the crash is fixed
>> for you.
>
> Yup, still works fine here, thanks,

Great, thanks for testing.



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-02-14  0:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <164470605041.16643.18195741888149501834@vcs2.savannah.gnu.org>
     [not found] ` <20220212224730.AE7C3C00891@vcs2.savannah.gnu.org>
2022-02-13  0:36   ` master 8e0b043f49: * src/xterm.c (x_update_opaque_region): Avoid crash at startup in Lucid build Po Lu
2022-02-13  0:47     ` Po Lu
2022-02-13 14:47       ` Stefan Monnier
2022-02-14  0:58         ` Po Lu

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).