* Re: [elpa] externals/org 6de5431acc: org: Refactor rx to concat + regexp-opt
[not found] ` <20220724145753.7E671C00602@vcs2.savannah.gnu.org>
@ 2022-07-24 16:03 ` Stefan Monnier
2022-07-27 3:01 ` Ihor Radchenko
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2022-07-24 16:03 UTC (permalink / raw)
To: TEC; +Cc: emacs-devel
> 'org-safe-remote-resources
> - (list (rx string-start
> - (literal
> - (if (and (= char ?f) current-file)
> - (concat "file://" current-file) uri))
> - string-end))))
> + (list (concat "\\`"
> + (regexp-opt
> + (if (and (= char ?f) current-file)
> + (concat "file://" current-file) uri))
> + "\\'"))))
Did you mean to use `regexp-quote` instead of `regexp-opt`, maybe?
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [elpa] externals/org 6de5431acc: org: Refactor rx to concat + regexp-opt
2022-07-24 16:03 ` [elpa] externals/org 6de5431acc: org: Refactor rx to concat + regexp-opt Stefan Monnier
@ 2022-07-27 3:01 ` Ihor Radchenko
0 siblings, 0 replies; 2+ messages in thread
From: Ihor Radchenko @ 2022-07-27 3:01 UTC (permalink / raw)
To: Stefan Monnier; +Cc: TEC, emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> 'org-safe-remote-resources
>> - (list (rx string-start
>> - (literal
>> - (if (and (= char ?f) current-file)
>> - (concat "file://" current-file) uri))
>> - string-end))))
>> + (list (concat "\\`"
>> + (regexp-opt
>> + (if (and (= char ?f) current-file)
>> + (concat "file://" current-file) uri))
>> + "\\'"))))
>
> Did you mean to use `regexp-quote` instead of `regexp-opt`, maybe?
Timothy has fixed the regexp in
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=6ad53fa22eab5830f85a401960dc1e7d00154a27
Note that this email address (tec@tecosaur.com) may be dysfunctional.
See https://list.orgmode.org/dd8a140cd218951f77c279a252b03f66@tecosaur.com/T/#u
Best,
Ihor
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-27 3:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <165867467321.24615.13379333890500235410@vcs2.savannah.gnu.org>
[not found] ` <20220724145753.7E671C00602@vcs2.savannah.gnu.org>
2022-07-24 16:03 ` [elpa] externals/org 6de5431acc: org: Refactor rx to concat + regexp-opt Stefan Monnier
2022-07-27 3:01 ` Ihor Radchenko
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).