unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu <luangruo@yahoo.com>
To: emacs-devel@gnu.org
Cc: Stefan Kangas <stefankangas@gmail.com>
Subject: Re: master e90a457c46: * src/xrdb.c (main) [TESTRM]: Replace gets with fgets.
Date: Thu, 08 Sep 2022 21:31:55 +0800	[thread overview]
Message-ID: <87r10m801g.fsf@yahoo.com> (raw)
In-Reply-To: <20220908104901.EC7E5C04F0B@vcs2.savannah.gnu.org> (Stefan Kangas's message of "Thu, 8 Sep 2022 06:49:01 -0400 (EDT)")

Stefan Kangas <stefankangas@gmail.com> writes:

> branch: master
> commit e90a457c46ca9463bf77cab2d34513c45269c938
> Author: Stefan Kangas <stefankangas@gmail.com>
> Commit: Stefan Kangas <stefankangas@gmail.com>
>
>     * src/xrdb.c (main) [TESTRM]: Replace gets with fgets.
> ---
>  src/xrdb.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/xrdb.c b/src/xrdb.c
> index faeea04a53..5ff25dde14 100644
> --- a/src/xrdb.c
> +++ b/src/xrdb.c
> @@ -589,14 +589,14 @@ main (int argc, char **argv)
>        char query_class[90];
>  
>        printf ("Name: ");
> -      gets (query_name);
> +      fgets (query_name, 90, stdin);
>  
>        if (strlen (query_name))
>  	{
>  	  char *value;
>  
>  	  printf ("Class: ");
> -	  gets (query_class);
> +	  fgets (query_class, 90, stdin);
>  
>  	  value = x_get_string_resource (&xdb, query_name, query_class);
>  

TESTRM has not worked for a long time and relies on XLIB_ILLEGAL_ACCESS,
which is not okay to use anymore.

I would rather it be removed.



  parent reply	other threads:[~2022-09-08 13:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <166263414162.19351.12274380239965486683@vcs2.savannah.gnu.org>
     [not found] ` <20220908104901.EC7E5C04F0B@vcs2.savannah.gnu.org>
2022-09-08 12:21   ` master e90a457c46: * src/xrdb.c (main) [TESTRM]: Replace gets with fgets Robert Pluim
2022-09-09  2:00     ` Stefan Kangas
2022-09-08 13:31   ` Po Lu [this message]
2022-09-08 21:10     ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r10m801g.fsf@yahoo.com \
    --to=luangruo@yahoo.com \
    --cc=emacs-devel@gnu.org \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).