From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master e90a457c46: * src/xrdb.c (main) [TESTRM]: Replace gets with fgets. Date: Thu, 08 Sep 2022 21:31:55 +0800 Message-ID: <87r10m801g.fsf@yahoo.com> References: <166263414162.19351.12274380239965486683@vcs2.savannah.gnu.org> <20220908104901.EC7E5C04F0B@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31892"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: Stefan Kangas To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 08 15:41:13 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oWHmL-0008BN-Bd for ged-emacs-devel@m.gmane-mx.org; Thu, 08 Sep 2022 15:41:13 +0200 Original-Received: from localhost ([::1]:48298 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oWHmK-0005NL-Da for ged-emacs-devel@m.gmane-mx.org; Thu, 08 Sep 2022 09:41:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59106) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWHdc-00021Y-IK for emacs-devel@gnu.org; Thu, 08 Sep 2022 09:32:12 -0400 Original-Received: from sonic301-31.consmr.mail.ne1.yahoo.com ([66.163.184.200]:34940) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oWHda-0003Gv-4l for emacs-devel@gnu.org; Thu, 08 Sep 2022 09:32:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1662643926; bh=IWQFstiEclJaxCLSrhMIcPK3tLy7EFV2PIQEPITmoNo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=IxqMDIiQ93b7kqs1qk0CNllzRfT6ktUM6Ukz9zTYCyrAfh/XKI+fklBG88h5mxzC1XlEToN+fq5rClYj1kT/SJP1K0ZRdBSMJEvqzP6NWmZ+JiynGMjkG4jxFT4eVwH0vJ/kll0tAKG8FjRvGESncLzIYHyJyVkIWTf7Xuzm8QIiccm5FOrQz50NpsdNwDkJ9rJxY3Q8JFFBuP4lgtTgWRTuFESuNg8KQZzucBdqdiCK0LWoEs3kkobstR6uXyCXDLpTD8bfypa8LfvDOlz62K0GilpmNUKnRo0j7HwPXJmp7l+ehzJafB9X9nan3Zw7+8UxVBZtJVVonpr3XAC3qA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1662643926; bh=bMLV0ayw980Hs+aIJKC6h4YHPv2SBY8dl7RWeQ6nTYN=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=datI+AtwdgpJNtiCpJteAgnFwTHglBby5rJq0nsedjYmAvf4wdu7yT0yt5CaqN8871EdjXzeSMF+XAmnEI9QjFchUvK0UACwBNy4CRrtNWLsaS3p5fdfRjItpm/EW52toRc9Q6SJBy3XWMbzIQm9Cm6ZzyPVJii+Y423ay3WAAOmU6T+LC+PA5s1LZHfejQVr9742njufd9EKXiZ9qzJy3DIi7r8h1dKKZbi62IRZQIm57RsItCe+8Mv9Y/wuE5uILE9c+2aecwMjaGwovnqJKUcCDHFsoE7o4ceA95YsvjUz380EVRV2xObYgl7lTpYez1nYr++RtG5eB7ZfJHiWg== X-YMail-OSG: JWMVCaEVM1mOMaweo48ayzCXeUcz3fjkydyp8UDT1lbz1lzTmN2v.atsFQENnKv Lr5MBRebvYMs2vd_qTI7wxSZKPbvRKGwjInsOTQmZj0yUonBCv2rasz0BjdXZGcOQS44Knnxc6Z. niTcici1JEjDQsz.UH8Y3WMTZ4NvYFsUPtNAZ6dI0Rbi5XxcMfehERGS_NBJ33dcnzRBV8ehiyUE dqiZ3zBqRuYEpaXHCRhQdk7n4szRpV2y6uw7Xi8f_xYd5MKGtremcvbVXWEZeGT.my4rSK6SyWNT Say1qw5n_PSjEU2DUBjtV2XOkR5rZQMPyEAXGgf9YBFkjCQ2Hg6J4dLvZUfOPrSCX0BfQxHzzzIH nsvqRuI1bZYfj.bOa4bgPRInqw0KWTcnYhgXRi4NxtbrzHwgz_hUAnDD0C.2LMCRFIrDneBZuavT 4raxLDJmiTJR4TOR5YKYNgc4FD.ho8M5nPxSMzYeiN9OwFEITncm5KLnTiaOfgFZrfwd6yNWKJtc MCkJSbG7Y5eJle9uxNe2kl5yzIFn5t2YxoWUZfAG06EC_1uztBosNRIehxGGbpdiIhACjp1pCC5u 291bdxVhphYNaDlKpxpMBX_8Jb7e890AyENQBg3mgg1UCbb7A_NwiLLLKBzvfaZ42YiLzHZfaFpw 0qyFF7DtvxaDuvN5_NxixVE4UopZfnK44shU83SDVv9GHwQbKqLa7Nqozec58mzo91oxkEh6ZBK_ xRC4aAcgeUNUDuiY2Cn9rQikwjlIOLmfXbDb4vj6sjxLtoqDC0HyvbZ49jw6zyjD0oXM04u3UuIF ZWx.hAW605cY9GjTKs18owbXTmK84K4pDVQk3XPUIf X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ne1.yahoo.com with HTTP; Thu, 8 Sep 2022 13:32:06 +0000 Original-Received: by hermes--canary-production-sg3-6bb8946c47-ts4tq (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 22ec010a78a9b8bfe8162d61a1061019; Thu, 08 Sep 2022 13:32:02 +0000 (UTC) In-Reply-To: <20220908104901.EC7E5C04F0B@vcs2.savannah.gnu.org> (Stefan Kangas's message of "Thu, 8 Sep 2022 06:49:01 -0400 (EDT)") X-Mailer: WebService/1.1.20612 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.184.200; envelope-from=luangruo@yahoo.com; helo=sonic301-31.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294954 Archived-At: Stefan Kangas writes: > branch: master > commit e90a457c46ca9463bf77cab2d34513c45269c938 > Author: Stefan Kangas > Commit: Stefan Kangas > > * src/xrdb.c (main) [TESTRM]: Replace gets with fgets. > --- > src/xrdb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/xrdb.c b/src/xrdb.c > index faeea04a53..5ff25dde14 100644 > --- a/src/xrdb.c > +++ b/src/xrdb.c > @@ -589,14 +589,14 @@ main (int argc, char **argv) > char query_class[90]; > > printf ("Name: "); > - gets (query_name); > + fgets (query_name, 90, stdin); > > if (strlen (query_name)) > { > char *value; > > printf ("Class: "); > - gets (query_class); > + fgets (query_class, 90, stdin); > > value = x_get_string_resource (&xdb, query_name, query_class); > TESTRM has not worked for a long time and relies on XLIB_ILLEGAL_ACCESS, which is not okay to use anymore. I would rather it be removed.