From: Michael Albinus <michael.albinus@gmx.de>
To: emacs-devel@gnu.org
Cc: Andrea Corallo <akrl@sdf.org>
Subject: Re: master c622627: * Clean-up temporary eln test-suite directory when exiting (bug#48060)
Date: Wed, 28 Apr 2021 13:30:37 +0200 [thread overview]
Message-ID: <87pmyebq8y.fsf@gmx.de> (raw)
In-Reply-To: <20210427213427.8318C20D0F@vcs0.savannah.gnu.org> (Andrea Corallo's message of "Tue, 27 Apr 2021 17:34:27 -0400 (EDT)")
akrl@savannah.gnu.org (Andrea Corallo) writes:
Hi Andrea,
> lisp/startup.el | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/startup.el b/lisp/startup.el
> index a21372a..3513ab7 100644
> --- a/lisp/startup.el
> +++ b/lisp/startup.el
> @@ -550,7 +550,9 @@ It is the default value of the variable `top-level'."
> ;; testsuite, add a temporary folder in front to produce there
> ;; new compilations.
> (when (equal (getenv "HOME") "/nonexistent")
> - (push (make-temp-file "emacs-testsuite-" t) comp-eln-load-path)))
> + (let ((tmp-dir (make-temp-file "emacs-testsuite-" t)))
> + (add-hook 'kill-emacs-hook (lambda () (delete-directory tmp-dir t)))
> + (push tmp-dir comp-eln-load-path))))
This expects, that Emacs tests are run only via calling test/Makefile
(which sets $HOME to "/nonexistent"). This is not true, tests can also
be started interactively.
And I find it problematic to have a dependency in startup.el to a
Makefile of the test directory.
Best regards, Michael.
next parent reply other threads:[~2021-04-28 11:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210427213426.6174.29110@vcs0.savannah.gnu.org>
[not found] ` <20210427213427.8318C20D0F@vcs0.savannah.gnu.org>
2021-04-28 11:30 ` Michael Albinus [this message]
2021-04-28 12:12 ` master c622627: * Clean-up temporary eln test-suite directory when exiting (bug#48060) Eli Zaretskii
2021-04-28 19:19 ` Andrea Corallo via Emacs development discussions.
2021-04-28 19:25 ` Eli Zaretskii
2021-04-28 19:45 ` Andrea Corallo via Emacs development discussions.
2021-04-29 5:20 ` Eli Zaretskii
2021-04-29 8:20 ` Andrea Corallo via Emacs development discussions.
2021-04-29 8:29 ` Andrea Corallo via Emacs development discussions.
2021-04-29 9:24 ` Eli Zaretskii
2021-04-29 14:41 ` Andrea Corallo via Emacs development discussions.
2021-04-29 15:11 ` Eli Zaretskii
2021-04-29 15:26 ` Michael Albinus
2021-04-29 15:47 ` Eli Zaretskii
2021-04-29 20:47 ` chad
2021-04-30 5:09 ` Eli Zaretskii
2021-04-29 9:21 ` Eli Zaretskii
2021-04-28 19:30 ` Michael Albinus
2021-04-28 19:47 ` Andrea Corallo via Emacs development discussions.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmyebq8y.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=akrl@sdf.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).