From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master c622627: * Clean-up temporary eln test-suite directory when exiting (bug#48060) Date: Wed, 28 Apr 2021 13:30:37 +0200 Message-ID: <87pmyebq8y.fsf@gmx.de> References: <20210427213426.6174.29110@vcs0.savannah.gnu.org> <20210427213427.8318C20D0F@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31261"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Andrea Corallo To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 28 13:32:05 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lbiQG-000809-Sa for ged-emacs-devel@m.gmane-mx.org; Wed, 28 Apr 2021 13:32:04 +0200 Original-Received: from localhost ([::1]:49384 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbiQF-0004L1-WC for ged-emacs-devel@m.gmane-mx.org; Wed, 28 Apr 2021 07:32:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43042) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbiP3-0003lO-Lp for emacs-devel@gnu.org; Wed, 28 Apr 2021 07:30:50 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:41447) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbiOy-0004Ya-2L for emacs-devel@gnu.org; Wed, 28 Apr 2021 07:30:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1619609439; bh=oqRQvrgO4n447+nABI+ONcJa37vUYc5eBXOxw0sLnKA=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=PfxD3a6MA6osfx0W91eDtZm6EqZiTDoPqpSeZicjHnRQAskbl/nsAO2oUkXRRelhT m41wxvCBpfpXWAAUg17mtKZykKGKeTxOm+/NsoD8EijEUWtWqUErSqSQhc6hpxQhd+ QzQpAeMpZzmC3U8ogP/wQRMXEOu2IxGVgKoZmAbA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([213.220.147.93]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MjS54-1l9qVR1X4s-00kz0D; Wed, 28 Apr 2021 13:30:39 +0200 In-Reply-To: <20210427213427.8318C20D0F@vcs0.savannah.gnu.org> (Andrea Corallo's message of "Tue, 27 Apr 2021 17:34:27 -0400 (EDT)") X-Provags-ID: V03:K1:f/rXe1LP243qXacMHmzNcF731LR0tics2/LQiZRI763K41ynf/N oiPQ8Z++tE09Jv4dhE2MsNQwu3gtZ8OzEPkWAO03rJJbK4UMk7zPISgf2w0qAXsAgT/wKar UshH7C+epO+bsDWlwuwFOCfGll9Y8p04yhfdWM5CzVwoM+0NIvbujnNqA9mPlpnDm9CIm9C 1MpkF327iyA1bYgNHyIXg== X-UI-Out-Filterresults: notjunk:1;V03:K0:DH2Z5EL/8qc=:/4pKEnBp1uuP1RCfO9DXa/ 7SCQ+ScyoVBf23fzEmDcBAO6RZa0Kz9jyiBQDL42exOpeWdE/FPveXnYJTgTe9Z48A8w98KVI NJ1sJHG41i5gf6P5ubCG0wMeZD6KoPcDTSeo+i53WMEd+bHn7hrV3gnbw3179aZkr/f0LfdKB aEVf2r0gft4vd6nenxZgMXJQ2BqacHzsdGnCetW0ZU5SVzu8hLp+1Yt9aBJdQ+1ZpP+3FKKtW ZowO+1HGR3VQ8dWxoN8azOFZindhZGNuaNzBNMC1+BtixHouwQLlRBTj50Drf7DyUAPkbZiec F4DI0+DqhnP4wmNB9ti4kqBA3wWCXc8ExblB1TYOCBqwQja7gp8DazunJWPLjcBwCCmVPhPww YJtsA8mLxDGSlSDmyj8mGZgDh+H1qI/f+S8Dkb6NPvRasI/a4J+8ppzRpmbW2YLP6HfY/AUK2 yREjeJxTx62MTpBcCn/pfXAayQUCC61oZ1YUz/XIYKTElQCX4+LD1ZbUayu14AL4nRNNhiz3w payR273C0C8J+/fHoXHc+uG+mbFO6JU6LKqxa2fv8/q8GgYM3mCfgGQztKmcmYeeLUMyHql27 ef3V3bJZ/LSpn/tzfI4iQNsmBlfgXTed4/tVBxmFqIR5J/XX880oZvQFiYguiWl43id0lrvIi nskGPJKgtGOHZvW9nanN+2At0Ka3N47AZR8LFU+c+4lC4Efm7dpygWNd5G0NsB+1KvvbEa38j wmbDQR0EPySD+GZnQXLXTEai9/8x5MnKg+zXQIpJRErbshP6t1tlSo/ZFmjphcB3cuK2bHfO Received-SPF: pass client-ip=212.227.17.22; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268561 Archived-At: akrl@savannah.gnu.org (Andrea Corallo) writes: Hi Andrea, > lisp/startup.el | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/lisp/startup.el b/lisp/startup.el > index a21372a..3513ab7 100644 > --- a/lisp/startup.el > +++ b/lisp/startup.el > @@ -550,7 +550,9 @@ It is the default value of the variable `top-level'." > ;; testsuite, add a temporary folder in front to produce there > ;; new compilations. > (when (equal (getenv "HOME") "/nonexistent") > - (push (make-temp-file "emacs-testsuite-" t) comp-eln-load-path))) > + (let ((tmp-dir (make-temp-file "emacs-testsuite-" t))) > + (add-hook 'kill-emacs-hook (lambda () (delete-directory tmp-dir t))) > + (push tmp-dir comp-eln-load-path)))) This expects, that Emacs tests are run only via calling test/Makefile (which sets $HOME to "/nonexistent"). This is not true, tests can also be started interactively. And I find it problematic to have a dependency in startup.el to a Makefile of the test directory. Best regards, Michael.