unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master 0ddc03cf8c: Fix minor inconsistencies in 'char-script-table'
       [not found] ` <20220117195113.2ED72C0DA30@vcs2.savannah.gnu.org>
@ 2022-01-17 21:35   ` Kévin Le Gouguec
  2022-01-18 14:26     ` Eli Zaretskii
  0 siblings, 1 reply; 2+ messages in thread
From: Kévin Le Gouguec @ 2022-01-17 21:35 UTC (permalink / raw)
  To: emacs-devel; +Cc: Eli Zaretskii

[-- Attachment #1: Type: text/plain, Size: 621 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

> @@ -253,7 +252,6 @@
>  	(gunjala-gondi #x11D60)
>  	(makasar #x11EE0)
>  	(cuneiform #x12000)
> -	(cuneiform-numbers-and-punctuation #x12400)
>  	(cypro-minoan #x12F90)
>  	(egyptian #x13000)
>  	(mro #x16A40)

Mmm, emacs -Q seems to complain now:

> Error (initialization): Creation of the default fontsets failed:
> (error Invalid script or charset name:
> cuneiform-numbers-and-punctuation)

Is something like the following in order?  (There's also another remnant
of cuneiform-numbers-and-punctuation in w32font.c; maybe it also
deserves the axe, but I can't test the change)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: cuneiform.patch --]
[-- Type: text/x-patch, Size: 407 bytes --]

diff --git a/lisp/international/fontset.el b/lisp/international/fontset.el
index cf82514095..bd557df180 100644
--- a/lisp/international/fontset.el
+++ b/lisp/international/fontset.el
@@ -765,7 +765,6 @@ setup-default-fontset
                     old-uyghur
 		    makasar
                     dives-akuru
-		    cuneiform-numbers-and-punctuation
 		    cuneiform
 		    egyptian
                     tangsa

[-- Attachment #3: Type: text/plain, Size: 51 bytes --]


(Hope I'm not missing something; apologies if so)

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: master 0ddc03cf8c: Fix minor inconsistencies in 'char-script-table'
  2022-01-17 21:35   ` master 0ddc03cf8c: Fix minor inconsistencies in 'char-script-table' Kévin Le Gouguec
@ 2022-01-18 14:26     ` Eli Zaretskii
  0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2022-01-18 14:26 UTC (permalink / raw)
  To: Kévin Le Gouguec; +Cc: emacs-devel

> From: Kévin Le Gouguec <kevin.legouguec@gmail.com>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Mon, 17 Jan 2022 22:35:01 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > @@ -253,7 +252,6 @@
> >  	(gunjala-gondi #x11D60)
> >  	(makasar #x11EE0)
> >  	(cuneiform #x12000)
> > -	(cuneiform-numbers-and-punctuation #x12400)
> >  	(cypro-minoan #x12F90)
> >  	(egyptian #x13000)
> >  	(mro #x16A40)
> 
> Mmm, emacs -Q seems to complain now:
> 
> > Error (initialization): Creation of the default fontsets failed:
> > (error Invalid script or charset name:
> > cuneiform-numbers-and-punctuation)
> 
> Is something like the following in order?

Yes, thanks.

> (There's also another remnant of cuneiform-numbers-and-punctuation
> in w32font.c; maybe it also deserves the axe, but I can't test the
> change)

That one was actually a subtle bug, so good riddance!



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-01-18 14:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <164244907287.6972.10392029635598311022@vcs2.savannah.gnu.org>
     [not found] ` <20220117195113.2ED72C0DA30@vcs2.savannah.gnu.org>
2022-01-17 21:35   ` master 0ddc03cf8c: Fix minor inconsistencies in 'char-script-table' Kévin Le Gouguec
2022-01-18 14:26     ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).