From: Michael Heerdegen <michael_heerdegen@web.de>
To: emacs-devel@gnu.org
Subject: Re: Is it valid to call isearch-filter-predicate outside isearch?
Date: Thu, 01 Jun 2023 01:10:49 +0200 [thread overview]
Message-ID: <87pm6g14hy.fsf@web.de> (raw)
In-Reply-To: 87o7m0k1li.fsf@localhost
Ihor Radchenko <yantar92@posteo.net> writes:
> > Evidently, that ship sailed a long time ago: "grep isearch-" yields
> > more than 60 hits in replace.el. And then there are many hits in
> > comint.el, dired-aux.el, info.el, and even in simple.el.
>
> Sure. I have no issue with this. That's why I asked to add a word of
> warning about the state of affairs to the docstring. It is not normal
> that major mode-specific predicates are used elsewhere.
This is not an appropriate description of reality: replace is more or
less a part of isearch, and nearly all of the other hits are of the type
"implement isearch behavior for this mode/ this place" (e.g. for the
minibuffer in "simple.el").
In few other places high-level isearch or query-replace functions are
called directly to start a search or a query-replace.
I found not one place where that predicate is called just because the
semantics seem useful. In most places only the variable binding is
modified.
Michael.
next prev parent reply other threads:[~2023-05-31 23:10 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-20 14:10 Is it valid to call isearch-filter-predicate outside isearch? Ihor Radchenko
2023-05-22 18:12 ` Juri Linkov
2023-05-31 10:08 ` Ihor Radchenko
2023-05-31 12:44 ` Eli Zaretskii
2023-05-31 12:56 ` Ihor Radchenko
2023-05-31 14:21 ` Eli Zaretskii
2023-05-31 14:38 ` Ihor Radchenko
2023-05-31 15:22 ` [External] : " Drew Adams
2023-06-01 8:10 ` Ihor Radchenko
2023-05-31 23:10 ` Michael Heerdegen [this message]
2023-06-01 11:48 ` Ihor Radchenko
2023-06-01 23:30 ` Michael Heerdegen
2023-06-02 8:58 ` Ihor Radchenko
2023-06-01 6:38 ` Juri Linkov
2023-06-01 11:44 ` Ihor Radchenko
2023-05-31 23:17 ` Michael Heerdegen
2023-06-01 5:55 ` Eli Zaretskii
2023-06-01 23:13 ` Michael Heerdegen
2023-06-01 0:40 ` Michael Heerdegen
2023-06-01 11:42 ` Ihor Radchenko
2023-06-01 16:21 ` Juri Linkov
2023-06-02 8:56 ` Ihor Radchenko
2023-06-01 23:22 ` Michael Heerdegen
2023-06-02 9:07 ` Ihor Radchenko
2023-06-02 13:36 ` [External] : " Drew Adams
2023-06-02 23:06 ` Michael Heerdegen
2023-06-03 8:35 ` Ihor Radchenko
2023-06-04 0:06 ` Michael Heerdegen
2023-06-17 13:05 ` Ihor Radchenko
2023-06-18 2:48 ` Michael Heerdegen
2023-06-18 11:31 ` Ihor Radchenko
2023-06-04 2:06 ` Michael Heerdegen
2023-06-18 10:31 ` Ihor Radchenko
2023-06-18 21:39 ` Michael Heerdegen
2023-06-19 10:44 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pm6g14hy.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).