From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.devel Subject: Re: Is it valid to call isearch-filter-predicate outside isearch? Date: Thu, 01 Jun 2023 01:10:49 +0200 Message-ID: <87pm6g14hy.fsf@web.de> References: <875y8nks9t.fsf@localhost> <86pm6sb5g8.fsf@mail.linkov.net> <87ttvsn77s.fsf@localhost> <83edmwfz6p.fsf@gnu.org> <87r0qwk6bz.fsf@localhost> <83ttvseg3k.fsf@gnu.org> <87o7m0k1li.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29132"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: emacs-devel@gnu.org Cancel-Lock: sha1:CP5fnBoGVQAj6lEVOy6emsVDr3U= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 01 01:11:47 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q4Uyo-0007Ok-Oa for ged-emacs-devel@m.gmane-mx.org; Thu, 01 Jun 2023 01:11:46 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q4Uy5-00089E-JX; Wed, 31 May 2023 19:11:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4Uy3-00087x-9e for emacs-devel@gnu.org; Wed, 31 May 2023 19:10:59 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4Uy1-000688-NE for emacs-devel@gnu.org; Wed, 31 May 2023 19:10:59 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1q4Uxy-0006V5-KC for emacs-devel@gnu.org; Thu, 01 Jun 2023 01:10:54 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306470 Archived-At: Ihor Radchenko writes: > > Evidently, that ship sailed a long time ago: "grep isearch-" yields > > more than 60 hits in replace.el. And then there are many hits in > > comint.el, dired-aux.el, info.el, and even in simple.el. > > Sure. I have no issue with this. That's why I asked to add a word of > warning about the state of affairs to the docstring. It is not normal > that major mode-specific predicates are used elsewhere. This is not an appropriate description of reality: replace is more or less a part of isearch, and nearly all of the other hits are of the type "implement isearch behavior for this mode/ this place" (e.g. for the minibuffer in "simple.el"). In few other places high-level isearch or query-replace functions are called directly to start a search or a query-replace. I found not one place where that predicate is called just because the semantics seem useful. In most places only the variable binding is modified. Michael.