unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Philip Kaludercic <philipk@posteo.net>
To: Tony Zorman <tonyzorman@mailbox.org>
Cc: emacs-devel@gnu.org
Subject: Re: package-vc support for :files keyword
Date: Tue, 19 Sep 2023 08:47:10 +0000	[thread overview]
Message-ID: <87pm2ebldd.fsf@posteo.net> (raw)
In-Reply-To: <87o7hzi82q.fsf@hyperspace> (Tony Zorman's message of "Mon, 18 Sep 2023 21:40:13 +0200")

Tony Zorman <tonyzorman@mailbox.org> writes:

> On Mon, Sep 18 2023 15:52, Philip Kaludercic wrote:
>>> I think that
>>>
>>>   $ rm foo.el
>>>   $ git update-index --assume-unchanged foo.el
>>>
>>> should work. It should merge cleanly (I've tried this out just now, and
>>> it worked, but I may have overlooked something). If it's part of the
>>> package description, then updating should work out of the box, since
>>> package-vc-upgrade also calls package-vc--unpack-1, which would execute
>>> the respective :early-shell-command again.
>>
>> Being a git-specific command, this shouldn't be added to package-vc
>> directly.  If there is a VCS agnostic/generalisable way of doing this,
>> then it could be added to VC.
>
> Ah, sometimes I forget that there are VCs other than Git—sorry :)
>
>> But for now, if I understand you correctly, you are suggesting that
>> users give package specifications like this:
>>
>> (foo :url "https://some.vcs/repository"
>>      ;; ...
>>      :early-shell-command "rm [all the files]; git update-index --assume-unchanged [all the files]")
>>
>> where [all the files] might change between updates.
>
> Yes, exactly.
>
>> At this point I continue to question the utility of emulating
>> MELPA-style :files attributes, unless there are concrete usability
>> issues.
>>
>> For the record, these are all the repositories in {Non,}GNU ELPA that
>> develop multiple packages in a single repository:
>>
>> [… 12 lines elided …]
>>
>> From what I understand, there is no technical necessity for this mode of
>> development?  I wonder how difficult it would be to push for a
>> one-package-one-repo approach.
>
> This is not just for multiple packages in a single repository—at least
> one has to somewhat broaden what "multiple packages" means. Some
> packages include small shims for bigger projects, and inadvertently
> require them as dependencies. The original issue[1] on the
> vc-use-package repo mentions org-ql[2], more specifically its helm
> integration in the form of helm-org-ql.el. Some people might not want to
> pull down helm as a dependency just for one file that they are not going
> to use anyways.
>
> I'm not sure how common of a situation this actually is, but at least
> for the big completion frameworks—helm and ivy—it's not totally unheard
> of.

Hmm, this is interesting example that I was not familiar with.  As an
alternative idea, do you think that using `:ignored-files' like
elpa-admin.el could be useful?  You could exclude all the files with
"soft-dependencies", that wouldn't be scraped in `package-vc--unpack-1'
when looking for dependency files.

Alternatively, since I am still not convinced that having
:early-shell-command built-in to package-vc is a good idea, one could
scatter a number of hooks around the code that could be used to extend
installation procedure with additional functionality, like a
:early-shell-command.

> [1]: https://github.com/slotThe/vc-use-package/issues/12
> [2]: https://github.com/alphapapa/org-ql/



  reply	other threads:[~2023-09-19  8:47 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-10 10:53 package-vc support for :files keyword Daniel Fleischer
2023-06-10 13:23 ` Philip Kaludercic
2023-06-10 14:20   ` Daniel Fleischer
2023-06-11  8:55     ` Philip Kaludercic
2023-06-11  9:30       ` Daniel Fleischer
2023-06-11 10:24         ` Philip Kaludercic
2023-09-18  7:25   ` Tony Zorman
2023-09-18  9:10     ` Philip Kaludercic
2023-09-18 14:43       ` Tony Zorman
2023-09-18 15:52         ` Philip Kaludercic
2023-09-18 18:54           ` Adam Porter
2023-09-19  8:37             ` Philip Kaludercic
2023-09-19 12:23               ` Adam Porter
2023-09-19 13:56                 ` Philip Kaludercic
2023-09-19 14:14                   ` Adam Porter
2023-09-18 19:40           ` Tony Zorman
2023-09-19  8:47             ` Philip Kaludercic [this message]
2023-09-19 13:48               ` Adam Porter
2023-09-19 14:00                 ` Philip Kaludercic
2023-09-19 14:17               ` Tony Zorman
2023-09-20  7:32                 ` Philip Kaludercic
2023-09-21 13:28                   ` Tony Zorman
2023-09-21 16:32                     ` Philip Kaludercic
     [not found]                   ` <87jzsgm82h.fsf@hyperspace>
2023-09-24 14:31                     ` Philip Kaludercic
2023-09-25 13:32                       ` Tony Zorman
2023-09-27 14:03                         ` Philip Kaludercic
2023-10-04  6:44                           ` Tony Zorman
2023-09-19 22:51             ` Jonas Bernoulli
2023-09-22 12:38               ` Stefan Kangas
2023-09-22 13:26                 ` Philip Kaludercic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pm2ebldd.fsf@posteo.net \
    --to=philipk@posteo.net \
    --cc=emacs-devel@gnu.org \
    --cc=tonyzorman@mailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).