From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: package-vc support for :files keyword Date: Tue, 19 Sep 2023 08:47:10 +0000 Message-ID: <87pm2ebldd.fsf@posteo.net> References: <87ttrshrib.fsf@hyperspace> <871qev6e53.fsf@posteo.net> <87r0mviltd.fsf@hyperspace> <871qevbhru.fsf@posteo.net> <87o7hzi82q.fsf@hyperspace> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25282"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Tony Zorman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 19 10:48:20 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qiWP5-0006LC-Qo for ged-emacs-devel@m.gmane-mx.org; Tue, 19 Sep 2023 10:48:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qiWO7-0006Ds-MP; Tue, 19 Sep 2023 04:47:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qiWO5-0006DV-7M for emacs-devel@gnu.org; Tue, 19 Sep 2023 04:47:17 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qiWO2-00080b-Hg for emacs-devel@gnu.org; Tue, 19 Sep 2023 04:47:16 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 5BF9A240027 for ; Tue, 19 Sep 2023 10:47:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1695113232; bh=Tre3PCJcybu3zrP8HzUoUyomDO4xsLa+QRxZxLnM1gw=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=Teq33Bi+OnYFeUbzWG2gX5aWw08FjSEcTDwtP90Odga+V00du6BpmH6DbuvRJVup1 g9EEOi9ARxbjMI8EU8fGqoApITzizXWQFKf82Q5yYHGIPJk+FMDVo3ji0I7b2SN8T8 /bSiN114AuzjE8Aj9zmmDiCsCS9XA1OWv+jQSIYvaV2zi/g29Ju04BuadezwSKUoce xzNqpDjzrJUKBJecbimUtkMPpjlnw/CfMr7RiOv+hrtNzJecXO3iAHgpE4iXILT4ZC tkFlCGWygyPgc8eTR7mirCLVC0xp/I2Va+obcRvVqyqnvGFPyOYVTcehySyHGg2WaE xaeMgcvc3wbpA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RqZzM116rz9s2F; Tue, 19 Sep 2023 10:47:11 +0200 (CEST) In-Reply-To: <87o7hzi82q.fsf@hyperspace> (Tony Zorman's message of "Mon, 18 Sep 2023 21:40:13 +0200") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310738 Archived-At: Tony Zorman writes: > On Mon, Sep 18 2023 15:52, Philip Kaludercic wrote: >>> I think that >>> >>> $ rm foo.el >>> $ git update-index --assume-unchanged foo.el >>> >>> should work. It should merge cleanly (I've tried this out just now, and >>> it worked, but I may have overlooked something). If it's part of the >>> package description, then updating should work out of the box, since >>> package-vc-upgrade also calls package-vc--unpack-1, which would execute >>> the respective :early-shell-command again. >> >> Being a git-specific command, this shouldn't be added to package-vc >> directly. If there is a VCS agnostic/generalisable way of doing this, >> then it could be added to VC. > > Ah, sometimes I forget that there are VCs other than Git=E2=80=94sorry :) > >> But for now, if I understand you correctly, you are suggesting that >> users give package specifications like this: >> >> (foo :url "https://some.vcs/repository" >> ;; ... >> :early-shell-command "rm [all the files]; git update-index --assume= -unchanged [all the files]") >> >> where [all the files] might change between updates. > > Yes, exactly. > >> At this point I continue to question the utility of emulating >> MELPA-style :files attributes, unless there are concrete usability >> issues. >> >> For the record, these are all the repositories in {Non,}GNU ELPA that >> develop multiple packages in a single repository: >> >> [=E2=80=A6 12 lines elided =E2=80=A6] >> >> From what I understand, there is no technical necessity for this mode of >> development? I wonder how difficult it would be to push for a >> one-package-one-repo approach. > > This is not just for multiple packages in a single repository=E2=80=94at = least > one has to somewhat broaden what "multiple packages" means. Some > packages include small shims for bigger projects, and inadvertently > require them as dependencies. The original issue[1] on the > vc-use-package repo mentions org-ql[2], more specifically its helm > integration in the form of helm-org-ql.el. Some people might not want to > pull down helm as a dependency just for one file that they are not going > to use anyways. > > I'm not sure how common of a situation this actually is, but at least > for the big completion frameworks=E2=80=94helm and ivy=E2=80=94it's not t= otally unheard > of. Hmm, this is interesting example that I was not familiar with. As an alternative idea, do you think that using `:ignored-files' like elpa-admin.el could be useful? You could exclude all the files with "soft-dependencies", that wouldn't be scraped in `package-vc--unpack-1' when looking for dependency files. Alternatively, since I am still not convinced that having :early-shell-command built-in to package-vc is a good idea, one could scatter a number of hooks around the code that could be used to extend installation procedure with additional functionality, like a :early-shell-command. > [1]: https://github.com/slotThe/vc-use-package/issues/12 > [2]: https://github.com/alphapapa/org-ql/