From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Matthew Bauer <mjbauer95@gmail.com>
Cc: Stefan Kangas <stefankangas@gmail.com>,
emacs-devel@gnu.org, Philip Kaludercic <philipk@posteo.net>
Subject: Re: [nongnu] elpa/nix-mode 91a317e425 2/2: Merge pull request #176 from lafrenierejm/reformatter
Date: Thu, 09 Feb 2023 11:17:51 +0000 [thread overview]
Message-ID: <87o7q3jdeo.fsf@tcd.ie> (raw)
In-Reply-To: <CAFnZKr345cPgbWonUOJz=3OjUStdKZNDZTFibGNBPohwN2GAPA@mail.gmail.com> (Matthew Bauer's message of "Wed, 8 Feb 2023 17:31:09 -0600")
Matthew Bauer [2023-02-08 17:31 -0600] wrote:
>> I think that is the best solution here, yes. Patches welcome, but
>> meanwhile perhaps this should be reported as a bug so we don't lose
>> track of it.
>
> To clarify, you are saying nix-mode should not depend on reformatter for it to work in ELPA?
Yes, there should be no hard dependency, at least while reformatter
continues to be unavailable in Emacs proper, GNU ELPA, or NonGNU ELPA.
Meanwhile, it is okay for nix-mode to use reformatter on the condition
that the latter is already installed, as an optional dependency.
> We can definitely revert the commit that introduced reformatter and avoid the dependency,
> but I want to make sure I understand correctly.
That's one option, but another solution is for reformatter to be added
to [Non]GNU ELPA, assuming its author and the [Non]GNU ELPA maintainers
are in favour of that (I have not yet found the time to pursue this).
Thanks,
--
Basil
prev parent reply other threads:[~2023-02-09 11:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <167354999339.24083.12015066505244176362@vcs2.savannah.gnu.org>
[not found] ` <20230112185953.C337AC004FD@vcs2.savannah.gnu.org>
2023-01-23 22:32 ` [nongnu] elpa/nix-mode 91a317e425 2/2: Merge pull request #176 from lafrenierejm/reformatter Basil L. Contovounesios
2023-01-27 10:22 ` Stefan Kangas
2023-01-29 5:18 ` Richard Stallman
2023-01-30 6:50 ` Stefan Kangas
2023-02-08 23:31 ` Matthew Bauer
2023-02-09 11:17 ` Basil L. Contovounesios [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7q3jdeo.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
--cc=mjbauer95@gmail.com \
--cc=philipk@posteo.net \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).