From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] elpa/nix-mode 91a317e425 2/2: Merge pull request #176 from lafrenierejm/reformatter Date: Thu, 09 Feb 2023 11:17:51 +0000 Message-ID: <87o7q3jdeo.fsf@tcd.ie> References: <167354999339.24083.12015066505244176362@vcs2.savannah.gnu.org> <20230112185953.C337AC004FD@vcs2.savannah.gnu.org> <87y1psop9g.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4761"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Stefan Kangas , emacs-devel@gnu.org, Philip Kaludercic To: Matthew Bauer Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 09 12:18:18 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pQ4wR-0000yp-Oi for ged-emacs-devel@m.gmane-mx.org; Thu, 09 Feb 2023 12:18:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pQ4wB-0002g9-UK; Thu, 09 Feb 2023 06:17:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQ4w8-0002Xo-RX for emacs-devel@gnu.org; Thu, 09 Feb 2023 06:17:58 -0500 Original-Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pQ4w7-00006v-7o for emacs-devel@gnu.org; Thu, 09 Feb 2023 06:17:56 -0500 Original-Received: by mail-wr1-x435.google.com with SMTP id bk16so1376425wrb.11 for ; Thu, 09 Feb 2023 03:17:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=ka3F9Dp25bbSnJjmMkl9nDOXmX1irD0cbHhzrN+sjas=; b=O38GGzDq7U0HsyImo4Sr+IzvqalA26rVDzo7zt2ZPKYqKnEOnrPoSLriHqNKLga4i+ 7J9I1iTtW2rMVj4EwAnhK/XlNBuhDWSxiVDT/CI2G7fnZT6LKHD0zOvK31QwWdzvO4DY jkKdMAmSk3u/mXkW9jZ36/AuDxQ6qHIQa6YD8RPK3r0Ywb2IUnmO+mNzm9vyRrz4Lw9L 4q5l/Y5t0kwLpjMlzNznCWI7AzsFgRmJAdGSluWl5XmkHIsHmIhqSPX32EnrnzLAK0Nn tcK2AkNyurajO8zfORLqEFSzJU1tl7iIx1wDwjjgUSgP1Niws/rJo9+yEZ+JzpkLTHQw 7NJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ka3F9Dp25bbSnJjmMkl9nDOXmX1irD0cbHhzrN+sjas=; b=SkkxTj+EEi63t2wKhNdFNyMWlZCzWEAiFYJOihKhqnxvcnG/59ccbVPNzRfLoQlCUY 8q0F3YUpj0wEUJzHe8hZRQ3kiBYF/mLoSAPRpns2fLlj2gzWBJ40GejwspBzyMjmcnzN co657gAT6J8QlFzslLaZofXwZrONnbg82tlx/ACx1LUu+cW35A0pQ4RaYKk/5XOOATnv IiMGq7AdtJ3dcZNeTJo9fVc5sAXp1r4ANmIkxmuvOCXxkGMO8MtKuK9Ggmldi6DaqFyi kheBnw3DHCvAov4BFOsdMVVIjlSUvQWXxW5ycQ4x2IwxN7UAb47xjqlB7RPpQPHAYP1H ePWQ== X-Gm-Message-State: AO0yUKUWR4OJ0dIB087fRnJp5W0W+rADWKYXV0eGkzc6FkJ7deczRk26 QmwK8secJFTvisSYxC7B7XlpDw== X-Google-Smtp-Source: AK7set/S6FLUdrPQGBkDgRv25l+23i8FykbsNPzkZVODOfKmqVeR1VXXNRmrb650ipiEFbaaxgDbeg== X-Received: by 2002:a5d:6791:0:b0:2c3:f00c:ebaa with SMTP id v17-20020a5d6791000000b002c3f00cebaamr10250459wru.4.1675941473144; Thu, 09 Feb 2023 03:17:53 -0800 (PST) Original-Received: from localhost ([109.78.48.70]) by smtp.gmail.com with ESMTPSA id h8-20020a05600c314800b003e11ad0750csm161709wmo.47.2023.02.09.03.17.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 03:17:52 -0800 (PST) In-Reply-To: (Matthew Bauer's message of "Wed, 8 Feb 2023 17:31:09 -0600") Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=contovob@tcd.ie; helo=mail-wr1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303074 Archived-At: Matthew Bauer [2023-02-08 17:31 -0600] wrote: >> I think that is the best solution here, yes. Patches welcome, but >> meanwhile perhaps this should be reported as a bug so we don't lose >> track of it. > > To clarify, you are saying nix-mode should not depend on reformatter for it to work in ELPA? Yes, there should be no hard dependency, at least while reformatter continues to be unavailable in Emacs proper, GNU ELPA, or NonGNU ELPA. Meanwhile, it is okay for nix-mode to use reformatter on the condition that the latter is already installed, as an optional dependency. > We can definitely revert the commit that introduced reformatter and avoid the dependency, > but I want to make sure I understand correctly. That's one option, but another solution is for reformatter to be added to [Non]GNU ELPA, assuming its author and the [Non]GNU ELPA maintainers are in favour of that (I have not yet found the time to pursue this). Thanks, -- Basil