unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Felix <felix.dick@web.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] change dired--find-possibly-alternative-file behaviour.
Date: Sun, 26 Feb 2023 14:14:59 +0100	[thread overview]
Message-ID: <87o7pgmunt.fsf@web.de> (raw)
In-Reply-To: <838rgkkfsi.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 431 bytes --]


Eli Zaretskii <eliz@gnu.org> writes:

>> From: Felix <felix.dick@web.de>
>> Cc:  emacs-devel@gnu.org
>> Date: Sun, 26 Feb 2023 08:22:12 +0100
>>
>>
>> Felix <felix.dick@web.de> writes:
>>
>> >
>> > Just to be absolutely save,
>> > (= (length (get-buffer-window-list)) 1))
>> > could be changed to
>>
>>  (< (length (get-buffer-window-list)) 2))
>>
>> of course.
>>
>> Should i resend the patch?
>
> It's safer if you do, thanks.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: dired.patch --]
[-- Type: text/x-patch, Size: 527 bytes --]

index 76499d0f520..55a5bbd9800 100644
--- a/lisp/dired.el
+++ b/lisp/dired.el
@@ -2728,7 +2728,8 @@ dired-find-file
 (defun dired--find-possibly-alternative-file (file)
   "Find FILE, but respect `dired-kill-when-opening-new-dired-buffer'."
   (if (and dired-kill-when-opening-new-dired-buffer
-           (file-directory-p file))
+           (file-directory-p file)
+           (< (length (get-buffer-window-list)) 2))
       (progn
         (set-buffer-modified-p nil)
         (dired--find-file #'find-alternate-file file))

  reply	other threads:[~2023-02-26 13:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-25 19:43 [PATCH] change dired--find-possibly-alternative-file behaviour Felix
2023-02-26  5:26 ` Eli Zaretskii
2023-02-26  6:07   ` Felix
2023-02-26  6:29     ` Eli Zaretskii
2023-02-26  6:32       ` Felix
2023-02-26  7:00         ` Eli Zaretskii
2023-02-26  7:01           ` Felix
2023-02-26  7:22             ` Felix
2023-02-26  8:10               ` Eli Zaretskii
2023-02-26 13:14                 ` Felix [this message]
2023-02-28 14:12                   ` Eli Zaretskii
2023-02-26  8:09             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7pgmunt.fsf@web.de \
    --to=felix.dick@web.de \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).