From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Felix Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] change dired--find-possibly-alternative-file behaviour. Date: Sun, 26 Feb 2023 14:14:59 +0100 Message-ID: <87o7pgmunt.fsf@web.de> References: <87mt51o5bu.fsf@web.de> <83ttz9j8up.fsf@gnu.org> <87y1olgdca.fsf@web.de> <83h6v9j5xm.fsf@gnu.org> <87ttz9gceo.fsf@web.de> <83bklgkj2h.fsf@gnu.org> <87lekkewfp.fsf@web.de> <87r0uc6g7v.fsf@web.de> <838rgkkfsi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24732"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.9.3; emacs 30.0.50 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Feb 26 14:23:30 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pWGzy-0006Hk-8y for ged-emacs-devel@m.gmane-mx.org; Sun, 26 Feb 2023 14:23:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pWGzJ-0007Hz-84; Sun, 26 Feb 2023 08:22:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWGzG-0007DQ-Up for emacs-devel@gnu.org; Sun, 26 Feb 2023 08:22:46 -0500 Original-Received: from mout.web.de ([212.227.17.11]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWGzB-0000Vi-D5; Sun, 26 Feb 2023 08:22:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1677417759; i=felix.dick@web.de; bh=XiNm1sjLjN0eieax+6uevJnNHxSMQ5tQIUW3qQZovxY=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:Date:In-reply-to; b=rYO7EdWIvfpWsT42ot2yuOTYd+8NgubGpshE+/pbPVYfhRB1sS6jo8MS6Sx19s6rk ljf7ayLn+snopYYqFPwip32cZlpsLvBMxi3Npl7RHJhcSPSLXdMu/8UWyBYMsdcicY fqPoJUVv8yD22OdF5Tx1zrZUG++etIMDGtHPMhDV27hQ6353X66+dS9kULnKRYiOy+ Wti+tBVglI0c3zxh8ce/KMCvI3QHszCz/aFgvjYw9bX0ihHiDUQYT/27Cq5XL3X63O AqhpHnbREyQOWh9MAgIEd2qOXnbtfwpaZxQBuLwgLb9o2T9b1TKN3Ou27IIQmvzEfF usbpIFaRWVh5A== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Original-Received: from felix-lifebooka531.web.de ([95.91.210.207]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1M1aHx-1pTEyi0aIV-003F9k; Sun, 26 Feb 2023 14:22:39 +0100 In-reply-to: <838rgkkfsi.fsf@gnu.org> X-Provags-ID: V03:K1:9bZwybhDsJPX5VABv0pQ9A5Smp4OO41DccvB2UFC0MKKpFquQr7 Gq6Auk9+dnO8Tw33Ms3PlmH/lmkdtJ2UX8pcLBmRGwH0jb1EQRtQCRLBjoiv0IC4t0XPOf+ p9ImYdRI5LJwmAXlZm3TZTWaY5nmc4nhgFHA60xP5qMyLLIQRudcyrtlex2Vh/3wH7vT99C jKWtm97O4QPdyT6IJE0+A== UI-OutboundReport: notjunk:1;M01:P0:aGzdJr1ZpIU=;fi8lxMjuSQ0G/rsBtN6KohK45ON lh9YldKvQVNUDiqRhkSAr0u3uF96DDWbBNb1NNoVyzPUjasrj8Xe1IkUJOlzynYe3gws5OoKx vWYMFbJUPGaoOYXu5CzOrXStoIvXfeockYz/WC4teIUl6KdiQpPLDaYr6pTajrLGsmGT1xaxV DIgfVUJPeHOfHMVJ0n3kUfO6Yo/P5aUVtJzD5JhuyJvqlyp44+vG4vyGAFJce5gXhKE9MweiA cT13E8KTB3+tGC+tLDQuxx67hW9W26NY6OD35D7rNzj/g9zieadw7EttHxObYhkAuzZZxEjqD duYREvqOsbBoWrSLKca3erDS5TjDG/gWVwHepweNszLp3aaE6Vp1Qknb6gY6WcQQE3PiW8k9t jcuRgjWkjtBG3jP1tmDs20rfoFHBQrv5Hc6Bl+hu1YtYrz3W7cMOZc1LNr69knsCZtQ8zgnI1 bPTiyDXEfXCs4CYLYWw6ZAVB9QarhxbnxFwiXHvXWQLUbEw0AUR6opQekNRTMCRJs1qZPJITV Rjw4YyudK+9j76/zAJKoWjPfu2cUAbsbr4BfG+j89JVsFc4FtkoH+XNNkH6pdc4ipm+kTZcr8 U5/irrpGIq7srkCAO9UOSg5gd/jqCC4pmgOpm6t/ncVzTDHtdYmrA34AlTI73nnOc/sCfZdui rPJbZ5cVUzSy7LVb6M6Q0j28y0ymE3yyWVLZ/vkA7Jw5RwB8u/+/Y8iofhGP+MnPJVsJwz6zb BjhLb3qvXJ5gwRsN349e/6bdg6YvH+v0NEr9tKVh/gXiTSQwFZI98hrpwdSE+vzuCCH9+wqQ Received-SPF: pass client-ip=212.227.17.11; envelope-from=felix.dick@web.de; helo=mout.web.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303822 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: Felix >> Cc: emacs-devel@gnu.org >> Date: Sun, 26 Feb 2023 08:22:12 +0100 >> >> >> Felix writes: >> >> > >> > Just to be absolutely save, >> > (= (length (get-buffer-window-list)) 1)) >> > could be changed to >> >> (< (length (get-buffer-window-list)) 2)) >> >> of course. >> >> Should i resend the patch? > > It's safer if you do, thanks. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=dired.patch index 76499d0f520..55a5bbd9800 100644 --- a/lisp/dired.el +++ b/lisp/dired.el @@ -2728,7 +2728,8 @@ dired-find-file (defun dired--find-possibly-alternative-file (file) "Find FILE, but respect `dired-kill-when-opening-new-dired-buffer'." (if (and dired-kill-when-opening-new-dired-buffer - (file-directory-p file)) + (file-directory-p file) + (< (length (get-buffer-window-list)) 2)) (progn (set-buffer-modified-p nil) (dired--find-file #'find-alternate-file file)) --=-=-=--