* Re: master 40db29f: * lisp/mail/sendmail.el (mail-from-style):
[not found] ` <20180703050723.A3056204E8@vcs0.savannah.gnu.org>
@ 2018-07-03 9:44 ` Robert Pluim
2018-07-03 15:49 ` Glenn Morris
0 siblings, 1 reply; 6+ messages in thread
From: Robert Pluim @ 2018-07-03 9:44 UTC (permalink / raw)
To: emacs-devel; +Cc: Glenn Morris
rgm@gnu.org (Glenn Morris) writes:
> (make-obsolete-variable
> 'mail-from-style
> - "Only the `angles' value is valid according to RFC2822" "27.1")
> + "only the `angles' value is valid according to RFC2822." "27.1" 'set)
This raises two questions. From 'emacs -Q', C-h v mail-from-style
gives:
mail-from-style is a variable defined in ‘sendmail.el’.
Its value is ‘default’
Original value was angles
Which implies that the value has been changed even though it hasnʼt.
Also, why does describe-variable only surround the
original value of the variable in quotes?
Robert
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: master 40db29f: * lisp/mail/sendmail.el (mail-from-style):
2018-07-03 9:44 ` master 40db29f: * lisp/mail/sendmail.el (mail-from-style): Robert Pluim
@ 2018-07-03 15:49 ` Glenn Morris
2018-07-03 18:05 ` Paul Eggert
2018-07-04 8:49 ` Robert Pluim
0 siblings, 2 replies; 6+ messages in thread
From: Glenn Morris @ 2018-07-03 15:49 UTC (permalink / raw)
To: emacs-devel
Robert Pluim wrote:
> This raises two questions.
Neither question seems related to my change, AFAICS?
> From 'emacs -Q', C-h v mail-from-style gives:
>
> mail-from-style is a variable defined in 'sendmail.el'.
> Its value is 'default'
> Original value was angles
I can't reproduce this.
> Also, why does describe-variable only surround the
> original value of the variable in quotes?
(I guess you mean, why does it not quote the original value?)
Perhaps an oversight in 36311ec?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: master 40db29f: * lisp/mail/sendmail.el (mail-from-style):
2018-07-03 15:49 ` Glenn Morris
@ 2018-07-03 18:05 ` Paul Eggert
2018-07-04 8:49 ` Robert Pluim
1 sibling, 0 replies; 6+ messages in thread
From: Paul Eggert @ 2018-07-03 18:05 UTC (permalink / raw)
To: Glenn Morris, emacs-devel
On 07/03/2018 08:49 AM, Glenn Morris wrote:
> Perhaps an oversight in 36311ec?
Hmm, well, even before 36311ec the old value was printed differently
from the new value. That is, in 36311ec I was hesitant to redo quoting
of old-values since they weren't quoted correctly via the old rules
either. It sounds like this should be rethought, as I don't see why
describe-variable should display old values in a different style from
new ones.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: master 40db29f: * lisp/mail/sendmail.el (mail-from-style):
2018-07-03 15:49 ` Glenn Morris
2018-07-03 18:05 ` Paul Eggert
@ 2018-07-04 8:49 ` Robert Pluim
2018-07-04 12:45 ` Andy Moreton
1 sibling, 1 reply; 6+ messages in thread
From: Robert Pluim @ 2018-07-04 8:49 UTC (permalink / raw)
To: Glenn Morris; +Cc: emacs-devel
Glenn Morris <rgm@gnu.org> writes:
> Robert Pluim wrote:
>
>> This raises two questions.
>
> Neither question seems related to my change, AFAICS?
>
>> From 'emacs -Q', C-h v mail-from-style gives:
>>
>> mail-from-style is a variable defined in 'sendmail.el'.
>> Its value is 'default'
>> Original value was angles
>
> I can't reproduce this.
Neither can I, after a 'make bootstrap'. Does the build cache custom
values somewhere?
>> Also, why does describe-variable only surround the
>> original value of the variable in quotes?
>
> (I guess you mean, why does it not quote the original value?)
Yes.
> Perhaps an oversight in 36311ec?
It was like that before 36311ec.
Regards
Robert
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: master 40db29f: * lisp/mail/sendmail.el (mail-from-style):
2018-07-04 8:49 ` Robert Pluim
@ 2018-07-04 12:45 ` Andy Moreton
2018-07-04 13:11 ` Robert Pluim
0 siblings, 1 reply; 6+ messages in thread
From: Andy Moreton @ 2018-07-04 12:45 UTC (permalink / raw)
To: emacs-devel
On Wed 04 Jul 2018, Robert Pluim wrote:
> Glenn Morris <rgm@gnu.org> writes:
>
>> Robert Pluim wrote:
>>
>>> This raises two questions.
>>
>> Neither question seems related to my change, AFAICS?
>>
>>> From 'emacs -Q', C-h v mail-from-style gives:
>>>
>>> mail-from-style is a variable defined in 'sendmail.el'.
>>> Its value is 'default'
>>> Original value was angles
>>
>> I can't reproduce this.
>
> Neither can I, after a 'make bootstrap'. Does the build cache custom
> values somewhere?
mail-from-style is an autoload, so ends up being defined in loaddefs.el.
It is possible that the default value in sendmail.el was different until
loaddefs.el was updated.
AndyM
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: master 40db29f: * lisp/mail/sendmail.el (mail-from-style):
2018-07-04 12:45 ` Andy Moreton
@ 2018-07-04 13:11 ` Robert Pluim
0 siblings, 0 replies; 6+ messages in thread
From: Robert Pluim @ 2018-07-04 13:11 UTC (permalink / raw)
To: Andy Moreton; +Cc: emacs-devel
Andy Moreton <andrewjmoreton@gmail.com> writes:
> On Wed 04 Jul 2018, Robert Pluim wrote:
>
>> Glenn Morris <rgm@gnu.org> writes:
>>
>>> Robert Pluim wrote:
>>>
>>>> This raises two questions.
>>>
>>> Neither question seems related to my change, AFAICS?
>>>
>>>> From 'emacs -Q', C-h v mail-from-style gives:
>>>>
>>>> mail-from-style is a variable defined in 'sendmail.el'.
>>>> Its value is 'default'
>>>> Original value was angles
>>>
>>> I can't reproduce this.
>>
>> Neither can I, after a 'make bootstrap'. Does the build cache custom
>> values somewhere?
>
> mail-from-style is an autoload, so ends up being defined in loaddefs.el.
> It is possible that the default value in sendmail.el was different until
> loaddefs.el was updated.
Yes, the default value changed a while ago. Looks like loaddefs.el
doesnʼt get updated in that case.
Robert
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-07-04 13:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20180703050722.22258.28686@vcs0.savannah.gnu.org>
[not found] ` <20180703050723.A3056204E8@vcs0.savannah.gnu.org>
2018-07-03 9:44 ` master 40db29f: * lisp/mail/sendmail.el (mail-from-style): Robert Pluim
2018-07-03 15:49 ` Glenn Morris
2018-07-03 18:05 ` Paul Eggert
2018-07-04 8:49 ` Robert Pluim
2018-07-04 12:45 ` Andy Moreton
2018-07-04 13:11 ` Robert Pluim
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).