* Re: [elpa] master 7a63b77: Add debbugs-*-tagged commands
[not found] ` <20191121144121.AB3C720C06@vcs0.savannah.gnu.org>
@ 2019-11-21 15:42 ` Stefan Monnier
2019-11-21 15:54 ` Michael Albinus
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2019-11-21 15:42 UTC (permalink / raw)
To: emacs-devel; +Cc: Michael Albinus
> + (cl-letf (((symbol-function 'debbugs-gnu-show-reports)
> + #'debbugs-org-show-reports))
Yuck. If we keep this functionality, it'd be worth introducing some
variable that we can set buffer-locally here instead of having to
let-bind a function like that.
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [elpa] master 7a63b77: Add debbugs-*-tagged commands
2019-11-21 15:42 ` [elpa] master 7a63b77: Add debbugs-*-tagged commands Stefan Monnier
@ 2019-11-21 15:54 ` Michael Albinus
2019-11-21 15:58 ` Stefan Monnier
0 siblings, 1 reply; 4+ messages in thread
From: Michael Albinus @ 2019-11-21 15:54 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> + (cl-letf (((symbol-function 'debbugs-gnu-show-reports)
>> + #'debbugs-org-show-reports))
>
> Yuck. If we keep this functionality, it'd be worth introducing some
> variable that we can set buffer-locally here instead of having to
> let-bind a function like that.
We could do, but is it really that bad using letf?
OTOH I doubt that debbugs-org is used by many users, rather by nobody. I
haven't seen any question about for years. So I'm in the mood to stop
it.
> Stefan
Best regards, Michael.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [elpa] master 7a63b77: Add debbugs-*-tagged commands
2019-11-21 15:54 ` Michael Albinus
@ 2019-11-21 15:58 ` Stefan Monnier
2019-11-22 16:39 ` Michael Albinus
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2019-11-21 15:58 UTC (permalink / raw)
To: Michael Albinus; +Cc: emacs-devel
>>> + (cl-letf (((symbol-function 'debbugs-gnu-show-reports)
>>> + #'debbugs-org-show-reports))
>> Yuck. If we keep this functionality, it'd be worth introducing some
>> variable that we can set buffer-locally here instead of having to
>> let-bind a function like that.
> We could do, but is it really that bad using letf?
It's like using an advice in your own code, only worse ;-)
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [elpa] master 7a63b77: Add debbugs-*-tagged commands
2019-11-21 15:58 ` Stefan Monnier
@ 2019-11-22 16:39 ` Michael Albinus
0 siblings, 0 replies; 4+ messages in thread
From: Michael Albinus @ 2019-11-22 16:39 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>>> + (cl-letf (((symbol-function 'debbugs-gnu-show-reports)
>>>> + #'debbugs-org-show-reports))
>>> Yuck. If we keep this functionality, it'd be worth introducing some
>>> variable that we can set buffer-locally here instead of having to
>>> let-bind a function like that.
>> We could do, but is it really that bad using letf?
>
> It's like using an advice in your own code, only worse ;-)
I've pushed a fix.
> Stefan
Best regards, Michael.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-22 16:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20191121144120.3671.37844@vcs0.savannah.gnu.org>
[not found] ` <20191121144121.AB3C720C06@vcs0.savannah.gnu.org>
2019-11-21 15:42 ` [elpa] master 7a63b77: Add debbugs-*-tagged commands Stefan Monnier
2019-11-21 15:54 ` Michael Albinus
2019-11-21 15:58 ` Stefan Monnier
2019-11-22 16:39 ` Michael Albinus
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).