From: Po Lu <luangruo@yahoo.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Andreas Schwab <schwab@linux-m68k.org>, emacs-devel@gnu.org
Subject: Re: Compiler warnings in dispnew.c
Date: Mon, 29 Nov 2021 08:35:50 +0800 [thread overview]
Message-ID: <87mtln6bo9.fsf@yahoo.com> (raw)
In-Reply-To: <83k0gswb6x.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 28 Nov 2021 17:29:26 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Andreas Schwab <schwab@linux-m68k.org>
>> Date: Sun, 28 Nov 2021 12:07:01 +0100
>> Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
>>
>> Does that work?
>>
>> diff --git a/src/dispnew.c b/src/dispnew.c
>> index f3f110a8f2..a976bf94c5 100644
>> --- a/src/dispnew.c
>> +++ b/src/dispnew.c
>> @@ -1034,7 +1034,7 @@ copy_row_except_pointers (struct glyph_row *to, struct glyph_row *from)
>> {
>> enum { off = offsetof (struct glyph_row, x) };
>>
>> - memcpy (&to->x, &from->x, sizeof *to - off);
>> + memcpy ((char *) to + off, (char *) from + off, sizeof *to - off);
>> }
>
> Po Lu, please try this and tell if the warning goes away.
>
> Thanks.
Yes, this makes it go away. Thanks.
next prev parent reply other threads:[~2021-11-29 0:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87fsrg7gdt.fsf.ref@yahoo.com>
2021-11-28 9:56 ` Compiler warnings in dispnew.c Po Lu
2021-11-28 10:48 ` Eli Zaretskii
2021-11-28 10:57 ` Andreas Schwab
2021-11-28 11:02 ` Po Lu
2021-11-28 11:07 ` Andreas Schwab
2021-11-28 15:29 ` Eli Zaretskii
2021-11-29 0:35 ` Po Lu [this message]
2021-11-29 17:49 ` Stefan Monnier
2021-11-29 17:53 ` Andreas Schwab
2021-11-28 11:03 ` Eli Zaretskii
2021-11-28 11:10 ` Andreas Schwab
2021-11-28 11:18 ` Eli Zaretskii
2021-11-28 11:44 ` Andreas Schwab
2021-11-28 11:11 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtln6bo9.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).