unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu <luangruo@yahoo.com>
To: emacs-devel@gnu.org
Subject: Compiler warnings in dispnew.c
Date: Sun, 28 Nov 2021 17:56:30 +0800	[thread overview]
Message-ID: <87fsrg7gdt.fsf@yahoo.com> (raw)
In-Reply-To: 87fsrg7gdt.fsf.ref@yahoo.com

Building with checking, I get:

  CC       dispnew.o
In function ‘copy_row_except_pointers’,
    inlined from ‘assign_row’ at dispnew.c:1050:3,
    inlined from ‘mirror_make_current’ at dispnew.c:2761:3:
dispnew.c:1037:3: warning: ‘memcpy’ offset [48, 255] from the object at ‘current_row’ is out of the bounds of referenced subobject ‘x’ with type ‘int’ at offset 44 [-Warray-bounds]
 1037 |   memcpy (&to->x, &from->x, sizeof *to - off);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from termchar.h:23,
                 from dispnew.c:28:
dispnew.c: In function ‘mirror_make_current’:
dispextern.h:885:7: note: subobject ‘x’ declared here
  885 |   int x, y;
      |       ^
In function ‘copy_row_except_pointers’,
    inlined from ‘assign_row’ at dispnew.c:1050:3,
    inlined from ‘make_current’ at dispnew.c:2719:3:
dispnew.c:1037:3: warning: ‘memcpy’ offset [48, 255] from the object at ‘current_row’ is out of the bounds of referenced subobject ‘x’ with type ‘int’ at offset 44 [-Warray-bounds]
 1037 |   memcpy (&to->x, &from->x, sizeof *to - off);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from termchar.h:23,
                 from dispnew.c:28:
dispnew.c: In function ‘make_current’:
dispextern.h:885:7: note: subobject ‘x’ declared here
  885 |   int x, y;
      |       ^
In function ‘copy_row_except_pointers’,
    inlined from ‘assign_row’ at dispnew.c:1050:3,
    inlined from ‘scrolling_window’ at dispnew.c:4445:4,
    inlined from ‘update_window’ at dispnew.c:3651:13:
dispnew.c:1037:3: warning: ‘memcpy’ offset [48, 255] from the object at ‘c’ is out of the bounds of referenced subobject ‘x’ with type ‘int’ at offset 44 [-Warray-bounds]
 1037 |   memcpy (&to->x, &from->x, sizeof *to - off);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from termchar.h:23,
                 from dispnew.c:28:
dispnew.c: In function ‘update_window’:
dispextern.h:885:7: note: subobject ‘x’ declared here
  885 |   int x, y;
      |       ^
In function ‘copy_row_except_pointers’,
    inlined from ‘assign_row’ at dispnew.c:1050:3,
    inlined from ‘scrolling_window’ at dispnew.c:4768:6,
    inlined from ‘update_window’ at dispnew.c:3651:13:
dispnew.c:1037:3: warning: ‘memcpy’ offset [48, 255] from the object at ‘to’ is out of the bounds of referenced subobject ‘x’ with type ‘int’ at offset 44 [-Warray-bounds]
 1037 |   memcpy (&to->x, &from->x, sizeof *to - off);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from termchar.h:23,
                 from dispnew.c:28:
dispnew.c: In function ‘update_window’:
dispextern.h:885:7: note: subobject ‘x’ declared here
  885 |   int x, y;

I think it would be prudent to fix this, thanks.



       reply	other threads:[~2021-11-28  9:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87fsrg7gdt.fsf.ref@yahoo.com>
2021-11-28  9:56 ` Po Lu [this message]
2021-11-28 10:48   ` Compiler warnings in dispnew.c Eli Zaretskii
2021-11-28 10:57     ` Andreas Schwab
2021-11-28 11:02     ` Po Lu
2021-11-28 11:07       ` Andreas Schwab
2021-11-28 15:29         ` Eli Zaretskii
2021-11-29  0:35           ` Po Lu
2021-11-29 17:49         ` Stefan Monnier
2021-11-29 17:53           ` Andreas Schwab
2021-11-28 11:03     ` Eli Zaretskii
2021-11-28 11:10       ` Andreas Schwab
2021-11-28 11:18         ` Eli Zaretskii
2021-11-28 11:44           ` Andreas Schwab
2021-11-28 11:11       ` Po Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fsrg7gdt.fsf@yahoo.com \
    --to=luangruo@yahoo.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).