From: Juri Linkov <juri@jurta.org>
Cc: rms@gnu.org, emacs-devel@gnu.org
Subject: Re: thumbs.el and transparency
Date: Sun, 12 Feb 2006 19:47:08 +0200 [thread overview]
Message-ID: <87lkwg4jkn.fsf@jurta.org> (raw)
In-Reply-To: <c99f54dd0602120638m735716c1kb43c35866b3988a1@mail.gmail.com> (Mattis's message of "Sun, 12 Feb 2006 15:38:19 +0100")
>> tumme.el is larger than most Lisp source files, but quite a few
>> are larger. If you want to split it into 2 or 3 files, please do.
>> But only do that if you feel that makes it clearer and more
>> maintainable.
>
> 570+ lines are Commentary and History
You can remove History without any doubt. This is the first thing that
is usually done after importing a new package into Emacs CVS.
> but yes, it has 2000+ lines of code which is quite much. I will think
> about a split, see if there are things that could be moved to make it
> easier to maintain, but I don't see it as an urgent thing to do
> right now.
What is needed to make tumme.el more maintainable right now is regrouping
functions and variables related to separate functionalities within one file.
Currently many related functions and variables are littered to different
parts of tumme.el. The standard way to group related code is like below:
^L
;;; Generate gallery
(defcustom tumme-gallery-dir ...
(defcustom tumme-gallery-hidden-tags ...
... other gallery user options
... gallery internal variables
...
(defun tumme-gallery-generate ()
...
... other gallery commands
--
Juri Linkov
http://www.jurta.org/emacs/
next prev parent reply other threads:[~2006-02-12 17:47 UTC|newest]
Thread overview: 127+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-25 1:08 thumbs.el and transparency Nick Roberts
2006-01-25 7:59 ` Juri Linkov
2006-01-25 9:20 ` Nick Roberts
2006-01-26 18:54 ` Mathias Dahl
2006-01-26 21:59 ` Nick Roberts
2006-01-27 3:46 ` Miles Bader
2006-01-27 9:27 ` Nick Roberts
2006-01-28 4:50 ` Richard M. Stallman
2006-01-28 23:58 ` Nick Roberts
2006-01-29 13:41 ` Mathias Dahl
2006-01-29 21:10 ` Nick Roberts
2006-01-29 22:42 ` Mathias Dahl
2006-01-30 10:26 ` Kim F. Storm
2006-01-30 11:23 ` Juanma Barranquero
2006-01-30 15:12 ` Chong Yidong
2006-01-30 15:41 ` Juanma Barranquero
2006-01-30 18:43 ` Chong Yidong
2006-01-31 15:31 ` CUA-related problem (was: Re: thumbs.el and transparency) Kim F. Storm
2006-01-31 15:41 ` Juanma Barranquero
2006-01-31 18:19 ` Luc Teirlinck
2006-01-31 19:32 ` Juanma Barranquero
2006-01-31 18:04 ` thumbs.el and transparency Richard M. Stallman
2006-01-31 19:47 ` Juanma Barranquero
2006-01-31 21:10 ` Luc Teirlinck
2006-01-31 23:08 ` Kim F. Storm
2006-01-31 23:45 ` Luc Teirlinck
2006-02-01 10:41 ` Kim F. Storm
2006-02-02 2:07 ` Luc Teirlinck
2006-02-02 9:26 ` Juanma Barranquero
2006-02-02 9:35 ` Kim F. Storm
2006-01-31 23:54 ` Luc Teirlinck
2006-02-01 10:45 ` Juanma Barranquero
2006-01-30 23:25 ` Richard M. Stallman
2006-01-31 9:26 ` Juanma Barranquero
2006-01-29 9:38 ` Sascha Wilde
2006-01-29 13:46 ` Mathias Dahl
2006-01-29 16:38 ` Miles Bader
2006-01-29 18:13 ` David Kastrup
2006-01-29 22:35 ` Mathias Dahl
2006-01-29 16:50 ` David Kastrup
2006-01-29 22:33 ` Mathias Dahl
2006-01-27 16:53 ` Mathias Dahl
2006-01-29 0:03 ` Nick Roberts
2006-01-30 0:56 ` Richard M. Stallman
2006-01-30 11:35 ` Mathias Dahl
2006-01-29 2:33 ` Miles Bader
2006-01-29 14:07 ` Mathias Dahl
2006-01-29 14:34 ` Mathias Dahl
2006-01-29 16:22 ` Robert J. Chassell
2006-01-29 18:01 ` Chong Yidong
2006-01-29 20:13 ` Nick Roberts
2006-01-30 1:04 ` Robert J. Chassell
2006-01-30 2:08 ` Nick Roberts
2006-01-30 14:44 ` Robert J. Chassell
2006-01-29 22:04 ` Mathias Dahl
2006-01-29 23:13 ` Chong Yidong
2006-01-30 11:57 ` Mathias Dahl
2006-01-30 14:18 ` Mathias Dahl
2006-01-30 1:49 ` Robert J. Chassell
2006-01-30 12:08 ` Mathias Dahl
2006-01-28 4:51 ` Richard M. Stallman
2006-01-29 16:01 ` Mathias Dahl
2006-01-30 18:46 ` Richard M. Stallman
2006-01-30 21:49 ` Mathias Dahl
2006-01-30 22:16 ` Mathias Dahl
2006-01-31 18:03 ` Richard M. Stallman
2006-02-01 10:44 ` Mathias Dahl
2006-02-02 4:16 ` Richard M. Stallman
2006-02-02 16:34 ` Mathias Dahl
2006-02-04 18:27 ` Richard M. Stallman
2006-02-05 12:03 ` Mathias Dahl
2006-02-05 20:36 ` Juri Linkov
2006-02-05 22:05 ` Mathias Dahl
2006-02-06 0:22 ` Miles Bader
2006-02-06 7:27 ` Juri Linkov
2006-02-06 17:37 ` Mathias Dahl
2006-02-07 10:59 ` Juri Linkov
2006-02-07 17:46 ` Mathias Dahl
2006-02-08 9:17 ` Juri Linkov
2006-02-08 15:27 ` Mathias Dahl
2006-02-09 17:29 ` Juri Linkov
2006-02-09 22:46 ` Mathias Dahl
2006-02-10 1:29 ` Juri Linkov
2006-02-10 10:14 ` Mathias Dahl
2006-02-10 10:28 ` Miles Bader
2006-02-10 13:45 ` tumme testing Robert J. Chassell
2006-02-10 14:26 ` Mattis
2006-02-10 18:18 ` Robert J. Chassell
2006-02-11 0:17 ` Mattis
2006-02-11 12:57 ` Robert J. Chassell
2006-02-11 21:54 ` Mathias Dahl
2006-02-11 1:22 ` Juri Linkov
2006-02-11 9:21 ` Mathias Dahl
2006-02-12 17:45 ` Juri Linkov
2006-02-12 21:21 ` Mathias Dahl
2006-02-12 23:41 ` Mathias Dahl
2006-02-13 0:24 ` Robert J. Chassell
2006-02-13 17:55 ` Juri Linkov
2006-02-13 18:41 ` Drew Adams
2006-02-14 6:18 ` Tomas Zerolo
2006-02-14 17:45 ` Juri Linkov
2006-02-13 20:21 ` Mathias Dahl
2006-02-10 16:47 ` Mathias Dahl
2006-02-11 16:45 ` thumbs.el and transparency Richard M. Stallman
2006-02-09 23:47 ` Miles Bader
2006-02-10 10:12 ` Mathias Dahl
2006-02-10 23:02 ` Richard M. Stallman
2006-02-10 23:56 ` Mathias Dahl
2006-02-11 1:21 ` Juri Linkov
2006-02-11 9:30 ` Mathias Dahl
2006-02-12 17:45 ` Juri Linkov
2006-02-12 18:35 ` Mathias Dahl
2006-02-12 4:30 ` Richard M. Stallman
2006-02-12 14:38 ` Mattis
2006-02-12 17:47 ` Juri Linkov [this message]
2006-02-12 18:39 ` Mathias Dahl
2006-02-13 17:57 ` Juri Linkov
2006-02-06 2:06 ` Richard M. Stallman
2006-02-06 21:19 ` Can someone verify my changes to tumme and dired? (was: thumbs.el and transparency) Mathias Dahl
2006-02-06 22:17 ` Can someone verify my changes to tumme and dired? Mathias Dahl
2006-02-06 23:33 ` David Kastrup
2006-02-07 12:58 ` Mathias Dahl
2006-01-27 4:12 ` thumbs.el and transparency Miles Bader
2006-01-27 4:50 ` Nick Roberts
-- strict thread matches above, loose matches on Subject: below --
2006-01-29 13:57 Xavier Maillard
2006-01-29 20:14 ` Nick Roberts
2006-01-29 22:11 ` Mathias Dahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lkwg4jkn.fsf@jurta.org \
--to=juri@jurta.org \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).