From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: thumbs.el and transparency Date: Sun, 12 Feb 2006 19:47:08 +0200 Organization: JURTA Message-ID: <87lkwg4jkn.fsf@jurta.org> References: <17366.53124.274532.548329@kahikatea.snap.net.nz> <87slqvfobk.fsf@jurta.org> <87d5hy43b6.fsf@jurta.org> <87u0b8lwhw.fsf@jurta.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1139767279 12788 80.91.229.2 (12 Feb 2006 18:01:19 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 12 Feb 2006 18:01:19 +0000 (UTC) Cc: rms@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 12 19:01:18 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1F8LX2-0007V5-UH for ged-emacs-devel@m.gmane.org; Sun, 12 Feb 2006 19:01:10 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F8LX2-0001S6-Ey for ged-emacs-devel@m.gmane.org; Sun, 12 Feb 2006 13:01:08 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1F8LUE-0000S6-OU for emacs-devel@gnu.org; Sun, 12 Feb 2006 12:58:15 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1F8LUB-0000Qa-F3 for emacs-devel@gnu.org; Sun, 12 Feb 2006 12:58:13 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F8LUB-0000QC-0j for emacs-devel@gnu.org; Sun, 12 Feb 2006 12:58:11 -0500 Original-Received: from [194.126.101.111] (helo=mail.neti.ee) by monty-python.gnu.org with esmtp (Exim 4.52) id 1F8LYO-0000ZW-8j; Sun, 12 Feb 2006 13:02:32 -0500 Original-Received: from mail.neti.ee (80-235-40-69-dsl.mus.estpak.ee [80.235.40.69]) by Relayhost2.neti.ee (Postfix) with ESMTP id 3D4B5801D; Sun, 12 Feb 2006 19:58:06 +0200 (EET) Original-To: Mattis In-Reply-To: (Mattis's message of "Sun, 12 Feb 2006 15:38:19 +0100") User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) X-Virus-Scanned: by amavisd-new-2.2.1 (20041222) (Debian) at neti.ee X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:50414 Archived-At: >> tumme.el is larger than most Lisp source files, but quite a few >> are larger. If you want to split it into 2 or 3 files, please do. >> But only do that if you feel that makes it clearer and more >> maintainable. > > 570+ lines are Commentary and History You can remove History without any doubt. This is the first thing that is usually done after importing a new package into Emacs CVS. > but yes, it has 2000+ lines of code which is quite much. I will think > about a split, see if there are things that could be moved to make it > easier to maintain, but I don't see it as an urgent thing to do > right now. What is needed to make tumme.el more maintainable right now is regrouping functions and variables related to separate functionalities within one file. Currently many related functions and variables are littered to different parts of tumme.el. The standard way to group related code is like below: ^L ;;; Generate gallery (defcustom tumme-gallery-dir ... (defcustom tumme-gallery-hidden-tags ... ... other gallery user options ... gallery internal variables ... (defun tumme-gallery-generate () ... ... other gallery commands -- Juri Linkov http://www.jurta.org/emacs/