From: Michael Albinus <michael.albinus@gmx.de>
To: Augusto Stoffel <arstoffel@gmail.com>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: [PATCH] Buffer-local process environments
Date: Sat, 28 Aug 2021 14:47:36 +0200 [thread overview]
Message-ID: <87lf4l91nb.fsf@gmx.de> (raw)
In-Reply-To: <87lf4lkb1w.fsf_-_@gmail.com> (Augusto Stoffel's message of "Sat, 28 Aug 2021 14:28:59 +0200")
Augusto Stoffel <arstoffel@gmail.com> writes:
Hi Augusto,
> diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
> index af7b8292b7..1c11b7707e 100644
> --- a/lisp/progmodes/compile.el
> +++ b/lisp/progmodes/compile.el
> @@ -1783,6 +1783,8 @@ compilation-start
> (replace-regexp-in-string "-mode\\'" "" (symbol-name mode))))
> (thisdir default-directory)
> (thisenv compilation-environment)
> + (bufferenv (when (local-variable-p 'process-environment)
> + (cons exec-path process-environment)))
W/o further reading, this cannot be right. Elements of
`process-environment' have always the syntax "VAR=VALUE". You add only a
VALUE (`exec-path') in `bufferenv'. I understand your intention, using
`bufferenv' as transportation vehicle, but I believe this is
mis-designed, and good for trouble. If not now, then later.
(I will review your proposal later, when this is fixed.)
Best regards, Michael.
next prev parent reply other threads:[~2021-08-28 12:47 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 10:56 Buffer-local process environments Augusto Stoffel
2021-04-29 12:30 ` Eli Zaretskii
2021-04-29 12:40 ` Augusto Stoffel
2021-04-29 12:52 ` Eli Zaretskii
2021-04-29 13:06 ` Augusto Stoffel
2021-04-29 14:02 ` Stefan Monnier
2021-04-29 17:26 ` Augusto Stoffel
2021-04-29 17:34 ` Michael Albinus
2021-04-30 7:29 ` Augusto Stoffel
2021-04-30 7:48 ` Michael Albinus
2021-04-30 15:19 ` Augusto Stoffel
2021-04-30 15:51 ` Michael Albinus
2021-05-02 6:13 ` Augusto Stoffel
2021-05-08 17:51 ` Michael Albinus
2021-05-09 5:06 ` Augusto Stoffel
2021-05-09 16:38 ` Michael Albinus
2021-08-28 12:28 ` [PATCH] " Augusto Stoffel
2021-08-28 12:37 ` Eli Zaretskii
2021-08-28 12:55 ` Augusto Stoffel
2021-09-01 10:42 ` Stephen Leake
2021-09-01 10:56 ` Augusto Stoffel
2021-09-01 22:38 ` Stephen Leake
2021-09-02 7:14 ` Augusto Stoffel
2021-09-06 15:17 ` Stephen Leake
2021-08-28 14:06 ` Arthur Miller
2021-08-28 14:33 ` Eli Zaretskii
2021-08-28 15:27 ` Arthur Miller
2021-08-28 15:38 ` Eli Zaretskii
2021-08-28 16:48 ` Arthur Miller
2021-08-28 15:39 ` Augusto Stoffel
2021-08-28 16:43 ` Arthur Miller
2021-08-28 12:47 ` Michael Albinus [this message]
2021-08-28 12:59 ` Augusto Stoffel
2021-08-28 13:18 ` Michael Albinus
2021-08-28 13:54 ` Augusto Stoffel
2021-08-28 14:05 ` Stefan Monnier
2021-08-28 15:19 ` Augusto Stoffel
2021-04-30 15:32 ` Augusto Stoffel
2021-04-30 15:55 ` Michael Albinus
2021-04-29 15:37 ` Michael Albinus
2021-04-29 17:31 ` Augusto Stoffel
2021-04-29 17:44 ` Michael Albinus
2021-04-30 7:00 ` Augusto Stoffel
2021-04-30 7:25 ` Michael Albinus
2021-05-02 13:45 ` Stephen Leake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lf4l91nb.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=arstoffel@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).