From: Philip Kaludercic <philipk@posteo.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Daniel Mendler <mail@daniel-mendler.de>, emacs-devel@gnu.org
Subject: Re: [elpa] externals/osm 05ac461360: Bail out earlier if dependencies are missing
Date: Wed, 11 May 2022 06:34:48 +0000 [thread overview]
Message-ID: <87lev84lx3.fsf@posteo.net> (raw)
In-Reply-To: <jwv35hgq1lq.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Tue, 10 May 2022 21:53:27 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> Daniel Mendler [2022-05-11 00:07:31] wrote:
>> On 5/10/22 23:00, Stefan Monnier wrote:
>
>> The alternative would be to replicate the check in all the
>> entry points to the package, the osm-mode, the autoloaded osm-*
>> commands, which would require more code.
>
> The "right" place for such checks is as soon as you know that you *will*
> definitely encounter an error.
>
> When the file is being loaded, you don't know yet that an error is
> inevitable because you don't know yet whether the loaded code will
> be called.
My understanding in this case is that the basic functionality of osm.el
requires efficient JSON parsing to be available. Without this, the
package becomes "prohibitively slow" (at least according to bug#55278).
Perhaps it would be better to add a helper function that does the check
and issues an error/warning, and call this at all entry-points?
prev parent reply other threads:[~2022-05-11 6:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <165221267003.11226.2207874159602256273@vcs2.savannah.gnu.org>
[not found] ` <20220510195750.558C1C01683@vcs2.savannah.gnu.org>
2022-05-10 21:00 ` [elpa] externals/osm 05ac461360: Bail out earlier if dependencies are missing Stefan Monnier
2022-05-10 22:07 ` Daniel Mendler
2022-05-11 1:53 ` Stefan Monnier
2022-05-11 6:34 ` Philip Kaludercic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lev84lx3.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=emacs-devel@gnu.org \
--cc=mail@daniel-mendler.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).