From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/osm 05ac461360: Bail out earlier if dependencies are missing Date: Wed, 11 May 2022 06:34:48 +0000 Message-ID: <87lev84lx3.fsf@posteo.net> References: <165221267003.11226.2207874159602256273@vcs2.savannah.gnu.org> <20220510195750.558C1C01683@vcs2.savannah.gnu.org> <04e511b4-f988-401b-92a4-32fce1b5e115@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9570"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Daniel Mendler , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 11 08:41:11 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nog22-0002EV-PX for ged-emacs-devel@m.gmane-mx.org; Wed, 11 May 2022 08:41:10 +0200 Original-Received: from localhost ([::1]:57672 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nog21-00084I-75 for ged-emacs-devel@m.gmane-mx.org; Wed, 11 May 2022 02:41:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33040) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nofw0-0005ic-OY for emacs-devel@gnu.org; Wed, 11 May 2022 02:34:58 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:53611) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nofvx-0005ZQ-GV for emacs-devel@gnu.org; Wed, 11 May 2022 02:34:55 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id D1F69240027 for ; Wed, 11 May 2022 08:34:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1652250889; bh=tWRQbzsVeQAhZepwOLTmpodFIIuDXmYYLTh9/wHIiII=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=J1bZRSYaWkJbY2nQP7Rqh+jjXLTMW8GeqXrI89HZxFi93ApCgXj9zBsz2MNwPL8iP WaBXzghQ5nT+bW+hRU6itQlncgmR9K2LAfDHBjNJPNrkME7zxlytX0PfFduFm/5KbU bOrnRiEuvHNiDdsmeVsDXhv2GsDUj1tBxZLxbWTQUDCLjOXJh1TzRz/zBbMvzxYnpS yrn/8qGzoEQSyUh983Ip7S3G65RjMWR3hyzAmlbQhGJy7qb+Dna48Vg+/m5ly3rarG 9sbrjmd0kcYv+egOcth2pPx82zGt9RNJe1BQYiO6K28/7DaK0tVfcr0SOTNhJDTBMV j8hj6subqJWoA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4KylWX61Cwz9rxQ; Wed, 11 May 2022 08:34:48 +0200 (CEST) Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB In-Reply-To: (Stefan Monnier's message of "Tue, 10 May 2022 21:53:27 -0400") Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289611 Archived-At: Stefan Monnier writes: > Daniel Mendler [2022-05-11 00:07:31] wrote: >> On 5/10/22 23:00, Stefan Monnier wrote: > >> The alternative would be to replicate the check in all the >> entry points to the package, the osm-mode, the autoloaded osm-* >> commands, which would require more code. > > The "right" place for such checks is as soon as you know that you *will* > definitely encounter an error. > > When the file is being loaded, you don't know yet that an error is > inevitable because you don't know yet whether the loaded code will > be called. My understanding in this case is that the basic functionality of osm.el requires efficient JSON parsing to be available. Without this, the package becomes "prohibitively slow" (at least according to bug#55278). Perhaps it would be better to add a helper function that does the check and issues an error/warning, and call this at all entry-points?