unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: wilde@sha-bang.de
To: emacs-devel@gnu.org
Cc: Pieter van Prooijen <pieter.van.prooijen@teloden.nl>
Subject: Compilation of src/xsettings.c fails when configured with --without_gsettings
Date: Sat, 14 May 2022 20:27:14 +0200	[thread overview]
Message-ID: <87lev4otq5.fsf@tammy.lan.sha-bang.de> (raw)

Hi *,

When HAVE_GSETTINGS is not defined (e.g. --without-gsettings
configuration option), but HAVE_PGTK is defined, then compilation of
src/xsettings.c fails with:

../../src/xsettings.c: In function ‘xsettings_get_font_options’:
../../src/xsettings.c:1163:35: error: ‘font_options’ undeclared (first use in this function)
 1163 |   return cairo_font_options_copy (font_options);
      |                                   ^~~~~~~~~~~~
../../src/xsettings.c:1163:35: note: each undeclared identifier is reported only once for each function it appears in
../../src/xsettings.c: In function ‘syms_of_xsettings’:
../../src/xsettings.c:1220:3: error: ‘font_options’ undeclared (first use in this function)
 1220 |   font_options = NULL;
      |   ^~~~~~~~~~~~

This happens due to the fact that: `font_options' is declared in L.231 which is guarded by
#ifdef HAVE_GSETTINGS
in L.209.

This was problem was most likely introduced with:

commit 526e9758de7d163ce3b25fde69a4e122ce9c3742
Author: Pieter van Prooijen <pieter.van.prooijen@teloden.nl>
Date:   Sun May 8 16:27:38 2022 +0200

    Use gsettings font rendering entries for pgtk builds

cheers,
sascha



             reply	other threads:[~2022-05-14 18:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-14 18:27 wilde [this message]
2022-05-14 19:44 ` Compilation of src/xsettings.c fails when configured with --without_gsettings Pieter van Prooijen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lev4otq5.fsf@tammy.lan.sha-bang.de \
    --to=wilde@sha-bang.de \
    --cc=emacs-devel@gnu.org \
    --cc=pieter.van.prooijen@teloden.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).