From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: wilde@sha-bang.de Newsgroups: gmane.emacs.devel Subject: Compilation of src/xsettings.c fails when configured with --without_gsettings Date: Sat, 14 May 2022 20:27:14 +0200 Message-ID: <87lev4otq5.fsf@tammy.lan.sha-bang.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40331"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (berkeley-unix) Cc: Pieter van Prooijen To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 14 20:27:59 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1npwUh-000AK9-4f for ged-emacs-devel@m.gmane-mx.org; Sat, 14 May 2022 20:27:59 +0200 Original-Received: from localhost ([::1]:55320 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1npwUf-0000j0-FG for ged-emacs-devel@m.gmane-mx.org; Sat, 14 May 2022 14:27:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47720) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npwU5-0008TC-Qf for emacs-devel@gnu.org; Sat, 14 May 2022 14:27:21 -0400 Original-Received: from mail.sha-bang.de ([2a01:4f8:110:34e1::42:1]:51966) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1npwU4-0001Hd-75 for emacs-devel@gnu.org; Sat, 14 May 2022 14:27:21 -0400 Original-Received: from tammy.sha-bang.de (tammy.sha-bang.de [IPv6:2001:470:69d1:bad:227:eff:fe11:1a71]) by mail.sha-bang.de (Postfix) with ESMTPSA id C662C2D0; Sat, 14 May 2022 20:27:15 +0200 (CEST) Original-Received: by tammy.sha-bang.de (Postfix, from userid 1000) id D4023667C; Sat, 14 May 2022 20:27:14 +0200 (CEST) Received-SPF: none client-ip=2a01:4f8:110:34e1::42:1; envelope-from=wilde@sha-bang.de; helo=mail.sha-bang.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289781 Archived-At: Hi *, When HAVE_GSETTINGS is not defined (e.g. --without-gsettings configuration option), but HAVE_PGTK is defined, then compilation of src/xsettings.c fails with: ../../src/xsettings.c: In function =E2=80=98xsettings_get_font_options=E2= =80=99: ../../src/xsettings.c:1163:35: error: =E2=80=98font_options=E2=80=99 undecl= ared (first use in this function) 1163 | return cairo_font_options_copy (font_options); | ^~~~~~~~~~~~ ../../src/xsettings.c:1163:35: note: each undeclared identifier is reported= only once for each function it appears in ../../src/xsettings.c: In function =E2=80=98syms_of_xsettings=E2=80=99: ../../src/xsettings.c:1220:3: error: =E2=80=98font_options=E2=80=99 undecla= red (first use in this function) 1220 | font_options =3D NULL; | ^~~~~~~~~~~~ This happens due to the fact that: `font_options' is declared in L.231 whic= h is guarded by #ifdef HAVE_GSETTINGS in L.209. This was problem was most likely introduced with: commit 526e9758de7d163ce3b25fde69a4e122ce9c3742 Author: Pieter van Prooijen Date: Sun May 8 16:27:38 2022 +0200 Use gsettings font rendering entries for pgtk builds cheers, sascha