From: Michael Albinus <michael.albinus@gmx.de>
To: emacs-devel@gnu.org
Cc: "Mattias Engdegård" <mattiase@acm.org>
Subject: Re: master d50e0bd 2/2: Use compiler macros for the key syntax checks
Date: Sun, 28 Nov 2021 18:56:27 +0100 [thread overview]
Message-ID: <87k0gscgfo.fsf@gmx.de> (raw)
In-Reply-To: <20211128171307.2DC5920B2A@vcs0.savannah.gnu.org> ("Mattias Engdegård"'s message of "Sun, 28 Nov 2021 12:13:07 -0500 (EST)")
Mattias Engdegård <mattiase@savannah.gnu.org> writes:
Hi Mattias,
> Use compiler macros for the key syntax checks
>
> Compile-time key string syntax checks are better written using
> compiler macros than with byte-hunk-handlers inside the compiler
> proper.
>
> * lisp/emacs-lisp/bytecomp.el (byte-compile-define-keymap)
> (byte-compile-define-keymap--define): Remove.
> * lisp/keymap.el (keymap--compile-check): New.
> (keymap-set, keymap-global-set, keymap-local-set, keymap-global-unset)
> (keymap-local-unset, keymap-unset, keymap-substitute)
> (keymap-set-after, key-translate, keymap-lookup, keymap-local-lookup)
> (keymap-global-lookup): Use compiler-macro for argument checks.
> * lisp/subr.el (define-keymap--compile): New.
> (define-keymap--define): Fold into define-keymap.
> (define-keymap): Use compiler-macro.
> (defvar-keymap): Use define-keymap.
> ---
> lisp/emacs-lisp/bytecomp.el | 63 ---------------------------------------------
> lisp/keymap.el | 22 +++++++++++++++-
> lisp/subr.el | 30 +++++++++++++++++----
> 3 files changed, 46 insertions(+), 69 deletions(-)
This fails on emba:
--8<---------------cut here---------------start------------->8---
#12 1510. Loading emacs-lisp/byte-run (source)...
#12 1510. Loading emacs-lisp/backquote (source)...
#12 1510. Loading subr (source)...
#12 1510. Symbol's function definition is void: remq
#12 1510. make[2]: *** [bootstrap-emacs.pdmp] Error 255
#12 1510. Makefile:907: recipe for target 'bootstrap-emacs.pdmp' failed
#12 1510. make[2]: Leaving directory '/checkout/src'
#12 1510. make[1]: *** [src] Error 2
#12 1510. make: *** [bootstrap] Error 2
#12 1510. Makefile:452: recipe for target 'src' failed
#12 1510. make[1]: Leaving directory '/checkout'
#12 1510. Makefile:1159: recipe for target 'bootstrap' failed
#12 ERROR: executor failed running [/bin/sh -c make bootstrap]: exit code: 2
--8<---------------cut here---------------end--------------->8---
See also <https://emba.gnu.org/emacs/emacs/-/jobs/34063/raw>.
Best regards, Michael.
prev parent reply other threads:[~2021-11-28 17:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211128171305.8769.17735@vcs0.savannah.gnu.org>
[not found] ` <20211128171307.2DC5920B2A@vcs0.savannah.gnu.org>
2021-11-28 17:47 ` master d50e0bd 2/2: Use compiler macros for the key syntax checks Lars Ingebrigtsen
2021-11-28 17:58 ` Eli Zaretskii
2021-11-28 18:14 ` Mattias Engdegård
2021-11-28 17:56 ` Michael Albinus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0gscgfo.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=emacs-devel@gnu.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).