From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master d50e0bd 2/2: Use compiler macros for the key syntax checks Date: Sun, 28 Nov 2021 18:56:27 +0100 Message-ID: <87k0gscgfo.fsf@gmx.de> References: <20211128171305.8769.17735@vcs0.savannah.gnu.org> <20211128171307.2DC5920B2A@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15176"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 28 18:57:19 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mrOQP-0003hS-EF for ged-emacs-devel@m.gmane-mx.org; Sun, 28 Nov 2021 18:57:17 +0100 Original-Received: from localhost ([::1]:39550 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mrOQN-0008Qm-SR for ged-emacs-devel@m.gmane-mx.org; Sun, 28 Nov 2021 12:57:15 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37634) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrOPn-0007lb-O3 for emacs-devel@gnu.org; Sun, 28 Nov 2021 12:56:39 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]:49415) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrOPh-00018d-RK for emacs-devel@gnu.org; Sun, 28 Nov 2021 12:56:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1638122189; bh=W0xPYmgF0NUMCSEt+HvYaxRIRHgTt8DNMus2UVAfFx0=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=EVO5Nlvdr4Vf30KMLnr5P+T+iNU6ZhnumU/D0ttHwA6SrsfoW9U9X5oITJpF4C5TU hLY+TEW6iRFYK2NhhqVioX/17lSQQe0wxFkvjIEJaL1Damb/X7s5gbFl4hVVLutmB3 bMee2nEsSkG0tBfjKP/DlIrlx2FlKMSiIGVXB2Po= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([213.220.148.120]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N8ofE-1mVn6Q444E-015pew; Sun, 28 Nov 2021 18:56:29 +0100 In-Reply-To: <20211128171307.2DC5920B2A@vcs0.savannah.gnu.org> ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Sun, 28 Nov 2021 12:13:07 -0500 (EST)") X-Provags-ID: V03:K1:ZJeQzBaPVhBkiZ3FhERiklLc9ZxIh9C5w5IAANTe2pMm8D/ZNJ/ cdVL9lmdkfQ2KlwGYLY173XUNdk8avFFct47mw+lpIf+DcVayo7m+8Ez1etB+WPNiQfgHCf 6fVkoeZ8enRXX5uaHCnr9bhIye6qJQhKxFlhl0ilZ8LJjFm4YmtToDwPEL1IqzYRvjm5ep9 8+SEj8Q5uQCZRUj+IJAEA== X-UI-Out-Filterresults: notjunk:1;V03:K0:eh0tqez5CyU=:JXEFi8dlQS8/sUGgPMT6+s P2qafbY2VKiMNlAUS+ht3iRMsIYc4HZB/rd2baRM7zJtOMXKE2/hCeCIvATXVsojkgzL2PyQZ CssN/Uy0JoA/qNyhsZoeeG79s2bRgQFVDicxtvb9KlpnXBRsgHRRocwN/m4p8LkXWkuHHlgee pneV1WYdjO8BE5kh+gZfBIId+7vyar+fdWL06wfEwKFQ3JJuF5mZKfI0gExHvBNboH2YyL+IK rV3/YTZl0awHpUmtHjuDPxhzeJBawArRssdjjP5mBs4JVFwGxoIb1kif/UheYYnPMXgjq3pm2 mJHLY6Rz7CcWF5wOfiARWuVobM2nVBlsa+JIZVz+pJ/Zi/4Jrhpu6ewfnGNiCOHKk1sKbtVsf w6RiI3cKYWh2HbcZHx3uArG4Xul/+5KHz+lKuB8EPIDyYSLMIgPYnUjHVuM4jHBGWa2a+dCAx haN04p/zxQHzhYL9LKM8Cm2MgHfD/JiIm7jSX9dhHV4F/YVeDD0VazPflGpzrGQ9nmCYl+MHB VrdaSILMyHVuPkEpwEkQ8aHXfWEGdCs9jPE6I23z/ai5neb94toLPfiBkzUT/UbyyFnjqPR5y GIqueWRQbOIoeUDvYi8/Z5i3f/6Eab8mQwZ77MZ5vLrEQrhgrnyCmtP9dG99WEUy8ByFk0K58 NsRKjmX6mhINfqyR2CawPLEh8eQ6K/syFUlQuYhl7QXkroYqVe6mqC3KBg5DpSEoA2MEqM0uD ajD/CGljob7cWQVQ6UuV9zJ/3JX93WnsVzmAX1YGXd4qjdVfuY5Z6UhOolOD9m/LhNDOEaEg Received-SPF: pass client-ip=212.227.15.19; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280434 Archived-At: Mattias Engdeg=C3=A5rd writes: Hi Mattias, > Use compiler macros for the key syntax checks >=20=20=20=20=20 > Compile-time key string syntax checks are better written using > compiler macros than with byte-hunk-handlers inside the compiler > proper. >=20=20=20=20=20 > * lisp/emacs-lisp/bytecomp.el (byte-compile-define-keymap) > (byte-compile-define-keymap--define): Remove. > * lisp/keymap.el (keymap--compile-check): New. > (keymap-set, keymap-global-set, keymap-local-set, keymap-global-unset) > (keymap-local-unset, keymap-unset, keymap-substitute) > (keymap-set-after, key-translate, keymap-lookup, keymap-local-lookup) > (keymap-global-lookup): Use compiler-macro for argument checks. > * lisp/subr.el (define-keymap--compile): New. > (define-keymap--define): Fold into define-keymap. > (define-keymap): Use compiler-macro. > (defvar-keymap): Use define-keymap. > --- > lisp/emacs-lisp/bytecomp.el | 63 ---------------------------------------= ------ > lisp/keymap.el | 22 +++++++++++++++- > lisp/subr.el | 30 +++++++++++++++++---- > 3 files changed, 46 insertions(+), 69 deletions(-) This fails on emba: --8<---------------cut here---------------start------------->8--- #12 1510. Loading emacs-lisp/byte-run (source)... #12 1510. Loading emacs-lisp/backquote (source)... #12 1510. Loading subr (source)... #12 1510. Symbol's function definition is void: remq #12 1510. make[2]: *** [bootstrap-emacs.pdmp] Error 255 #12 1510. Makefile:907: recipe for target 'bootstrap-emacs.pdmp' failed #12 1510. make[2]: Leaving directory '/checkout/src' #12 1510. make[1]: *** [src] Error 2 #12 1510. make: *** [bootstrap] Error 2 #12 1510. Makefile:452: recipe for target 'src' failed #12 1510. make[1]: Leaving directory '/checkout' #12 1510. Makefile:1159: recipe for target 'bootstrap' failed #12 ERROR: executor failed running [/bin/sh -c make bootstrap]: exit code: 2 --8<---------------cut here---------------end--------------->8--- See also . Best regards, Michael.