Re: master 63255de48b: * src/pdumper.c (dump_vectorlike): Handle PVEC_SYMBOL_WITH_POS.

Re: master 63255de48b: * src/pdumper.c (dump_vectorlike): Handle PVEC_SYMBOL_WITH_POS.

[Po Lu]

Andreas Schwab <schwab@gnu.org> writes:

>     * src/pdumper.c (dump_vectorlike): Handle PVEC_SYMBOL_WITH_POS.
> ---
>  src/pdumper.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/pdumper.c b/src/pdumper.c
> index 60280fcb04..f4e8e4af28 100644
> --- a/src/pdumper.c
> +++ b/src/pdumper.c
> @@ -2948,7 +2948,7 @@ dump_vectorlike (struct dump_context *ctx,
>                   Lisp_Object lv,
>                   dump_off offset)
>  {
> -#if CHECK_STRUCTS && !defined HASH_pvec_type_19F6CF5169
> +#if CHECK_STRUCTS && !defined HASH_pvec_type_AFF6FED5BD
>  # error "pvec_type changed. See CHECK_STRUCTS comment in config.h."
>  #endif
>    const struct Lisp_Vector *v = XVECTOR (lv);
> @@ -3032,6 +3032,8 @@ dump_vectorlike (struct dump_context *ctx,
>        error_unsupported_dump_object (ctx, lv, "sqlite");
>      case PVEC_MODULE_FUNCTION:
>        error_unsupported_dump_object (ctx, lv, "module function");
> +    case PVEC_SYMBOL_WITH_POS:
> +      error_unsupported_dump_object (ctx, lv, "symbol with pos");
>      default:
>        error_unsupported_dump_object(ctx, lv, "weird pseudovector");
>      }

Hmm, why not actually dump those symbols?  I think it makes sense to do
so, though admittedly didn't take a very close look at their
implementation.

Thanks.

Re: master 63255de48b: * src/pdumper.c (dump_vectorlike): Handle PVEC_SYMBOL_WITH_POS.

[Andreas Schwab]

On Jan 27 2022, Po Lu wrote:

> Hmm, why not actually dump those symbols?

They are not supposed to survive, and haven't so far (otherwise dumping
would have failed).

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."