unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Welsh Duggan <mwd@md5i.com>
To: Alan Mackenzie <acm@muc.de>
Cc: Gregory Heytings <gregory@heytings.org>,
	 Lars Ingebrigtsen <larsi@gnus.org>,
	 Eli Zaretskii <eliz@gnu.org>,
	 emacs-devel@gnu.org
Subject: Re: src/Makefile unhelpful
Date: Sat, 17 Sep 2022 12:41:28 -0400	[thread overview]
Message-ID: <87k06254xz.fsf@md5i.com> (raw)
In-Reply-To: <YyWtiIHKJNABNeTZ@ACM> (Alan Mackenzie's message of "Sat, 17 Sep 2022 11:20:40 +0000")

Alan Mackenzie <acm@muc.de> writes:

> Hello, Gregory.
>
> On Sat, Sep 17, 2022 at 10:46:24 +0000, Gregory Heytings wrote:
>
>> Complete patch attached, comments welcome.
>
> Just a small point in English usage:
>
>> I added a (minimal) sanity check, too.  I remember at least one case when 
>> make "failed to fail", it returned 0 even though the build did in fact not 
>> succeed.
>
>> +
>> +# ADVICE-ON-FAILURE-BEGIN
>> +#   You might consider to:
>> +#   - run "make bootstrap", which might fix the problem
>> +#   - run "git clean -fdx" and run "make" again, which might fix
>> +#     the problem if it was not fixed by "make bootstrap"
>> +#     !BEWARE! "git clean -fdx" restores the local repository in its
>> +#     !BEWARE! pristine state, it deletes all local changes and all
>> +#     !BEWARE! untracked files
>> +#   - run "make V=1", which displays the full commandes invoked by
>> +#     make, to further investigate the problem
>> +# ADVICE-ON-FAILURE-END
>> +
>
> The verb "consider" takes a gerund (or noun), not an infinitive.  So the
> above really ought to be:
>
>     You might consider:
>     - running ....
>
> , with the other "run"s being changed to "running", too.  Alternatively,
> one could use instead the verb "try", which can take an infinitive (or a
> gerund or noun ;-).

Also, for completeness sake, "commands" instead of "commandes".

-- 
Michael Welsh Duggan
(md5i@md5i.com)



  reply	other threads:[~2022-09-17 16:41 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-07  2:19 src/Makefile unhelpful Richard Stallman
2022-09-07  2:38 ` Po Lu
2022-09-07  2:41 ` Eli Zaretskii
2022-09-08  3:00   ` Richard Stallman
2022-09-08  4:51     ` Sam James
2022-09-11  3:38       ` Richard Stallman
2022-09-11  5:34         ` Eli Zaretskii
2022-09-11  9:57           ` Lars Ingebrigtsen
2022-09-11 11:59             ` Po Lu
2022-09-11 12:07               ` Eli Zaretskii
2022-09-11 12:16                 ` Lars Ingebrigtsen
2022-09-13  4:07               ` Richard Stallman
2022-09-13 16:11                 ` Eli Zaretskii
2022-09-14 20:02                   ` Alfred M. Szmidt
2022-09-14 20:05                     ` Lars Ingebrigtsen
2022-09-14 20:47                       ` Gregory Heytings
2022-09-15  7:14                         ` Lars Ingebrigtsen
2022-09-15  7:28                           ` Gregory Heytings
2022-09-15  7:32                             ` Eli Zaretskii
2022-09-15  7:41                               ` Gregory Heytings
2022-09-15  9:07                                 ` Eli Zaretskii
2022-09-15 14:33                             ` Óscar Fuentes
2022-09-15 16:04                               ` Gregory Heytings
2022-09-17 10:46                             ` Gregory Heytings
2022-09-17 11:20                               ` Alan Mackenzie
2022-09-17 16:41                                 ` Michael Welsh Duggan [this message]
2022-09-17 22:59                                   ` Gregory Heytings
2022-09-17 22:58                                 ` Gregory Heytings
2022-09-18 10:37                               ` Lars Ingebrigtsen
2022-09-18 11:38                                 ` Gerd Möllmann
2022-09-18 11:53                                   ` Andreas Schwab
2022-09-18 12:05                                     ` Gerd Möllmann
2022-09-18 13:48                                       ` Robert Pluim
2022-09-18 16:40                                     ` Gregory Heytings
2022-09-18 16:59                                       ` Andreas Schwab
2022-09-18 21:50                                         ` Gregory Heytings
2022-09-19 17:20                                           ` chad
2022-09-19 17:25                                             ` Eli Zaretskii
2022-09-19 20:42                                             ` Stefan Monnier
2022-09-18 21:39                                 ` Gregory Heytings
2022-09-15 13:13                           ` Ken Brown
2022-09-15 14:01                             ` Gregory Heytings
2022-09-11 15:16           ` Werner LEMBERG
2022-09-12  4:35             ` Richard Stallman
2022-09-08  6:14     ` Eli Zaretskii
2022-09-08  7:29       ` Andreas Schwab
2022-09-08 13:18       ` Stefan Monnier
2022-09-11  3:38       ` Richard Stallman
2022-09-11  5:42         ` Eli Zaretskii
2022-09-14  4:12           ` Richard Stallman
2022-09-14 11:33             ` Eli Zaretskii
2022-09-07  3:11 ` Sam James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k06254xz.fsf@md5i.com \
    --to=mwd@md5i.com \
    --cc=acm@muc.de \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=gregory@heytings.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).