From: Po Lu <luangruo@yahoo.com>
To: emacs-devel@gnu.org
Cc: Vibhav Pant <vibhavp@gmail.com>
Subject: Re: feature/asan-gc-poisoning aa9ca2c1493 2/2: src/alloc.c: Fix incorrect pointer arithmetic.
Date: Mon, 05 Dec 2022 09:13:59 +0800 [thread overview]
Message-ID: <87k036ps88.fsf@yahoo.com> (raw)
In-Reply-To: <20221204171657.3636BC00B0F@vcs2.savannah.gnu.org> (Vibhav Pant's message of "Sun, 4 Dec 2022 12:16:57 -0500 (EST)")
Vibhav Pant <vibhavp@gmail.com> writes:
> branch: feature/asan-gc-poisoning
> commit aa9ca2c1493f1cd9d50698747fd054b1be53dc95
> Author: Vibhav Pant <vibhavp@gmail.com>
> Commit: Vibhav Pant <vibhavp@gmail.com>
>
> src/alloc.c: Fix incorrect pointer arithmetic.
>
> * src/alloc.c (live_float_holding): Use parenthesis around the
> pointer arithmetic expression to untag 'cp' correctly.
> ---
> src/alloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/alloc.c b/src/alloc.c
> index 31108837e5a..6b8a4cdcc02 100644
> --- a/src/alloc.c
> +++ b/src/alloc.c
> @@ -5104,7 +5104,7 @@ live_float_holding (struct mem_node *m, void *p)
> && (b != float_block
> || offset / sizeof b->floats[0] < float_block_index))
> {
> - struct Lisp_Float *f = (struct Lisp_Float *) cp - off;
> + struct Lisp_Float *f = (struct Lisp_Float *) (cp - off);
> #if GC_ASAN_POISON_OBJECTS
> if (__asan_region_is_poisoned (f, sizeof (*f)))
> return NULL;
This is a problem on master and emacs-29 too, right?
next parent reply other threads:[~2022-12-05 1:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <167017421615.20730.5839006885061308371@vcs2.savannah.gnu.org>
[not found] ` <20221204171657.3636BC00B0F@vcs2.savannah.gnu.org>
2022-12-05 1:13 ` Po Lu [this message]
2022-12-05 13:06 ` feature/asan-gc-poisoning aa9ca2c1493 2/2: src/alloc.c: Fix incorrect pointer arithmetic Eli Zaretskii
2022-12-05 20:01 ` Vibhav Pant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k036ps88.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=emacs-devel@gnu.org \
--cc=vibhavp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).