From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: feature/asan-gc-poisoning aa9ca2c1493 2/2: src/alloc.c: Fix incorrect pointer arithmetic. Date: Mon, 05 Dec 2022 09:13:59 +0800 Message-ID: <87k036ps88.fsf@yahoo.com> References: <167017421615.20730.5839006885061308371@vcs2.savannah.gnu.org> <20221204171657.3636BC00B0F@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10123"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Vibhav Pant To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 05 02:14:57 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p204O-0002VV-06 for ged-emacs-devel@m.gmane-mx.org; Mon, 05 Dec 2022 02:14:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p203j-000741-76; Sun, 04 Dec 2022 20:14:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p203i-00073q-Ba for emacs-devel@gnu.org; Sun, 04 Dec 2022 20:14:14 -0500 Original-Received: from sonic307-10.consmr.mail.ne1.yahoo.com ([66.163.190.33]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p203g-0005Nl-Q7 for emacs-devel@gnu.org; Sun, 04 Dec 2022 20:14:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1670202848; bh=gT4zPx3dHttS0X48S7lRDpX15fzP02VoBw+XEugnO3A=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=r9SmVN5itLU/Xl5uMaMOYRw1t9S9RhtEEWNOuv9nu18kV3XRHYWImt8d99GyQH50bgGOSUBtMZJ3+oCfh4BPV6UoUqFu4NRkqoHRxoeo1UxH4hkSAVTd+hAIrCP3BkIP4CWEodHS1ZgnVG6PAQitKRL8MCW6dr3fUkM8hHiNw6Tem5qJ/sqodFSTxUKYekVS0hgrQ3Vp4WDAwOpL3t42GACeDRjDvfi1ngtkn2k0ucY5qHHXhs6SuV+AsZLyYi0IuekxjlB5kxwYu1WGPcqE0pjejquO2Jq9AfffarZ+UFrXbqN3ttdr7NAUSvAtgzqNXcJwEr9O1+SpNKzxXuyN2A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1670202848; bh=WScAE3nbMAMRjJTxC2exCt1pxCl0PZppfn6HPEW/5au=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=rAMH3K5ORXawSx1QX6PaPAAr/WOqemMNJLy162uqXvqsq4/vMJqHi4FW5l6IcXo5oVKZ3WGtodNGnz3YrqvOdzmy4DHxVChkHc6oH1QJLP/IGirIB4eFIG2TZ5TjulsgEBAOmPMuTYFUfsJi+Nq/CE53+XA3qo655/rTvjCwaUlHCX8P5LkDe9RLPu2R7DiIxodIx4TRsAqv5uwlFH9kP4ex1NyIBm1decL7mudWJpiEOm4XYOYxPkSSm+VE+BC8rfHJSnIyCWfkDTemQzmM0g1j2kSgyEjWs3O3QT66W5B8zVvyOUbMYm9JVvlPb8+h1pgK589hjY21kQ6epEbn+g== X-YMail-OSG: rqhqneUVM1mvJcDC9AoJHCzlQsCnr3UkacyE2B1h.tgxJ4aT2qSFjBGAi84BELm z0TFXDmI.TIhVL4.pNJbgUFx100ORCutK7CK9MxqFbAaipAepjzNj4UT9iuz4QekP7Gtw2Ci9HKv qRzIK5bg6QzSupaJFruzwDJMjnFMw8TfmEBcJiHtt3mAL09AeuRkdZAsQa6JL9AY_SL2D1YfK2oR t.bXe2x7e6c0C_4Ls62rgO0oqusjWc027mhIdnkfC9UdmY4Uv4eJZEgX2SxoaNQvP0y5nFf4gTsi NLPvAwI5bCLxF3_HQ7w4AOeGuJ66s5fTe3ESpZ1KdNDOog.rVXyqyvDX.qoKhr2VDpyOXF_FALd_ 4IOC5UZJQfTb3yq1kHkVKqQbH9p6LUl56tecRN1gaerZ5PHCu5w0patmBHiOatrf4b2hdCqyeZK6 iNtwlTE6rpkUA5AVvXeUE0ZR47D.ng9fypfEEChIJqV75pTi_YMQ7nnXn457Lz8H9m7zfxHoXGOA dE3WNMVe_DQdnfEmNCfQdw_kmI6Ng7WGnax5jNXJtvQ_Qv6K8B85ptKd1.II9PDFA4epMEJ.6_ZE kfmZFn38BLIvrILpirOZIoN8DqjSFbjXpdOHk_0fAJbl5CT.vfCTeCrd8Bn87nFosAOXj3M9jBki f5eexECC8va6MoUcEzfVO9Um.HtGYLkLECoiPKFruUmQ4c2dcOwp3crHH1zjsrdBxW1uFRkgK.EQ 40KLGFR.d6m8eefS65M..sBU9ErHEQ27l6qiGFKXT6rdn.wVdtIXclHtGW9lXQTIztyjfbzovpZT JmWUGo08_bwmXuF7IIMI_KztGV_5Cm1m9tddE.WoF1 X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Mon, 5 Dec 2022 01:14:08 +0000 Original-Received: by hermes--production-sg3-b666c6484-p5z8r (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 53f3fbd75447451ce997e6221dc8cc8e; Mon, 05 Dec 2022 01:14:05 +0000 (UTC) In-Reply-To: <20221204171657.3636BC00B0F@vcs2.savannah.gnu.org> (Vibhav Pant's message of "Sun, 4 Dec 2022 12:16:57 -0500 (EST)") X-Mailer: WebService/1.1.20926 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.190.33; envelope-from=luangruo@yahoo.com; helo=sonic307-10.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300914 Archived-At: Vibhav Pant writes: > branch: feature/asan-gc-poisoning > commit aa9ca2c1493f1cd9d50698747fd054b1be53dc95 > Author: Vibhav Pant > Commit: Vibhav Pant > > src/alloc.c: Fix incorrect pointer arithmetic. > > * src/alloc.c (live_float_holding): Use parenthesis around the > pointer arithmetic expression to untag 'cp' correctly. > --- > src/alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/alloc.c b/src/alloc.c > index 31108837e5a..6b8a4cdcc02 100644 > --- a/src/alloc.c > +++ b/src/alloc.c > @@ -5104,7 +5104,7 @@ live_float_holding (struct mem_node *m, void *p) > && (b != float_block > || offset / sizeof b->floats[0] < float_block_index)) > { > - struct Lisp_Float *f = (struct Lisp_Float *) cp - off; > + struct Lisp_Float *f = (struct Lisp_Float *) (cp - off); > #if GC_ASAN_POISON_OBJECTS > if (__asan_region_is_poisoned (f, sizeof (*f))) > return NULL; This is a problem on master and emacs-29 too, right?