From: "Óscar Fuentes" <ofv@wanadoo.es>
To: Le Wang <l26wang@gmail.com>
Cc: Leo Liu <sdl.web@gmail.com>, emacs-devel@gnu.org
Subject: Re: fix for bug 10994 breaks ido customizations in major way
Date: Sat, 04 May 2013 10:58:03 +0200 [thread overview]
Message-ID: <87ip2zm89w.fsf@wanadoo.es> (raw)
In-Reply-To: <CAM=K+iofPdYnSJt055tXSQ2g8xsNy3d1HbDHn4mbd0peFxD_DA@mail.gmail.com> (Le Wang's message of "Sat, 4 May 2013 15:00:24 +0800")
Le Wang <l26wang@gmail.com> writes:
> On Sat, May 4, 2013 at 4:33 AM, Leo Liu <sdl.web@gmail.com> wrote:
>
>> On 2013-05-03 20:49 +0800, Le Wang wrote:
>> > There are a few ido customizations floating around that propertizes text.
>> > This will break all of them. I don't think this fix is acceptable.
>>
>> That I wouldn't know. I only know what is in emacs and that the fix has
>> been in use for a while. Feel free to propose a different fix
>>
>
> Sure, I've attached a patch that deletes duplicates.
This change introduces a serious slowdown which is noticeable for large
candidate lists (try with 10000 elements.) The slowdown happens on every
invocation.
It is obvious that having duplicate candidates makes no sense, but at
the same time scanning the list in advance for all duplicates is
expensive. I'll suggest detecting and removing the duplicates on the
navigation functions, maybe just the adjacent duplicates (using the list
as a ring.)
Another "fix" could be to require a duplicate-free list for
ido-complete.
next prev parent reply other threads:[~2013-05-04 8:58 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 17:57 fix for bug 10994 breaks ido customizations in major way Le Wang
2013-05-03 4:13 ` Leo Liu
2013-05-03 12:49 ` Le Wang
2013-05-03 20:33 ` Leo Liu
2013-05-04 7:00 ` Le Wang
2013-05-04 8:58 ` Óscar Fuentes [this message]
2013-05-04 13:00 ` Le Wang
2013-05-05 10:57 ` Óscar Fuentes
2013-05-05 11:39 ` Leo Liu
2013-05-05 12:20 ` Óscar Fuentes
2013-05-05 12:58 ` Leo Liu
2013-05-05 13:38 ` Óscar Fuentes
2013-05-05 14:31 ` Stephen J. Turnbull
2013-05-05 15:26 ` Óscar Fuentes
2013-05-06 15:11 ` Le Wang
2013-05-06 22:49 ` Vitalie Spinu
2013-05-07 1:01 ` Óscar Fuentes
2013-05-07 9:35 ` Le Wang
2013-05-07 10:26 ` Vitalie Spinu
2013-05-07 10:35 ` Óscar Fuentes
2013-05-07 14:49 ` Le Wang
2013-05-07 21:18 ` Stefan Monnier
2013-05-07 14:42 ` Le Wang
2013-05-07 14:44 ` Drew Adams
2013-05-07 14:47 ` Le Wang
2013-05-07 19:00 ` Vitalie Spinu
2013-05-07 19:53 ` Óscar Fuentes
2013-05-08 0:04 ` Leo Liu
2013-05-08 0:35 ` Le Wang
2013-05-08 3:10 ` Leo Liu
2013-05-08 3:29 ` Leo Liu
2013-05-08 4:49 ` Leo Liu
2013-05-08 8:14 ` Vitalie Spinu
2013-05-08 8:42 ` Leo Liu
2013-05-08 12:23 ` Le Wang
2013-05-08 14:29 ` Leo Liu
2013-05-08 20:56 ` Juri Linkov
2013-05-10 1:52 ` Leo Liu
2013-05-17 2:48 ` Leo Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ip2zm89w.fsf@wanadoo.es \
--to=ofv@wanadoo.es \
--cc=emacs-devel@gnu.org \
--cc=l26wang@gmail.com \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).