unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* emacs lisp library name conflicts
@ 2016-05-07 15:03 Mike F
  2016-05-07 16:39 ` Nicolas Petton
  0 siblings, 1 reply; 3+ messages in thread
From: Mike F @ 2016-05-07 15:03 UTC (permalink / raw)
  To: rubikitch, emacs-devel, nicolas

[-- Attachment #1: Type: text/plain, Size: 775 bytes --]

Hi Guys,

There is a conflict in command names between libraries
seq.el and sequential-command.el.
They both define a command seq-count.
Pasted in the two defuns below.

Any recommendations?

Thanks
Mike Fitzgerald


## MTF from sequential-command.el
(defun seq-count ()
  "Returns number of times `this-command' was executed.
It also updates `seq-start-position'."
  (if (eq last-command this-command)
      (incf seq-store-count)
    (setq seq-start-position  (cons (point) (window-start))
          seq-store-count     0)))

## MTF from seq.el
(defun seq-count (pred seq)
  "Return the number of elements for which (PRED element) is non-nil in
SEQ."
  (let ((count 0))
    (seq-doseq (elt seq)
      (when (funcall pred elt)
        (setq count (+ 1 count))))
    count))

[-- Attachment #2: Type: text/html, Size: 1115 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: emacs lisp library name conflicts
  2016-05-07 15:03 emacs lisp library name conflicts Mike F
@ 2016-05-07 16:39 ` Nicolas Petton
  2016-05-11  1:54   ` John Wiegley
  0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Petton @ 2016-05-07 16:39 UTC (permalink / raw)
  To: Mike F, rubikitch, emacs-devel

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

Mike F <mikef656@gmail.com> writes:

> Hi Guys,

Hi,

> There is a conflict in command names between libraries
> seq.el and sequential-command.el.
> They both define a command seq-count.
> Pasted in the two defuns below.
>
> Any recommendations?

I guess sequential-command.el should not use the seq- prefix.

Nico

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: emacs lisp library name conflicts
  2016-05-07 16:39 ` Nicolas Petton
@ 2016-05-11  1:54   ` John Wiegley
  0 siblings, 0 replies; 3+ messages in thread
From: John Wiegley @ 2016-05-11  1:54 UTC (permalink / raw)
  To: Nicolas Petton; +Cc: Mike F, rubikitch, emacs-devel

[-- Attachment #1: Type: text/plain, Size: 491 bytes --]

>>>>> Nicolas Petton <nicolas@petton.fr> writes:

>> There is a conflict in command names between libraries
>> seq.el and sequential-command.el.
>> They both define a command seq-count.
>> Pasted in the two defuns below.
>> 
>> Any recommendations?

> I guess sequential-command.el should not use the seq- prefix.

I agree.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 629 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-05-11  1:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-07 15:03 emacs lisp library name conflicts Mike F
2016-05-07 16:39 ` Nicolas Petton
2016-05-11  1:54   ` John Wiegley

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).