From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-26 bd5795e: Fix url-copy-file arglist
Date: Thu, 23 May 2019 01:48:47 +0100 [thread overview]
Message-ID: <87imu26ln4.fsf@tcd.ie> (raw)
In-Reply-To: <874l5uv1oi.fsf@tcd.ie> (Basil L. Contovounesios's message of "Thu, 16 May 2019 16:50:21 +0100")
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>>> (defun url-copy-file (url newname &optional ok-if-already-exists
>>> - _keep-time _preserve-uid-gid)
>>> + _keep-time _preserve-uid-gid _preserve-permissions)
>>
>> Maybe we should just do
>>
>> (defun url-copy-file (url newname &optional ok-if-already-exists &rest _)
>
> I agree. More importantly, an integral ok-if-already-exists should be
> handled as in copy-file. How's the following?
Added some more function quotes to the patch following an off-list
suggestion and pushed to master[1].
[1: 72047556fa]: Fix url-copy-file argument handling
2019-05-23 01:41:00 +0100
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=72047556fa391016ab507c02c2f489c97b53f088
Thanks,
--
Basil
prev parent reply other threads:[~2019-05-23 0:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190320015752.17217.37491@vcs0.savannah.gnu.org>
[not found] ` <20190320015752.D768B20552@vcs0.savannah.gnu.org>
2019-03-20 2:25 ` [Emacs-diffs] emacs-26 bd5795e: Fix url-copy-file arglist Stefan Monnier
2019-05-16 15:50 ` Basil L. Contovounesios
2019-05-23 0:48 ` Basil L. Contovounesios [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imu26ln4.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).