From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-26 bd5795e: Fix url-copy-file arglist Date: Thu, 23 May 2019 01:48:47 +0100 Message-ID: <87imu26ln4.fsf@tcd.ie> References: <20190320015752.17217.37491@vcs0.savannah.gnu.org> <20190320015752.D768B20552@vcs0.savannah.gnu.org> <874l5uv1oi.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="99427"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 23 02:49:41 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hTbvQ-000Pic-F2 for ged-emacs-devel@m.gmane.org; Thu, 23 May 2019 02:49:40 +0200 Original-Received: from localhost ([127.0.0.1]:55224 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTbvP-0006w7-2O for ged-emacs-devel@m.gmane.org; Wed, 22 May 2019 20:49:39 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54416) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTbuk-0006vv-3Z for emacs-devel@gnu.org; Wed, 22 May 2019 20:48:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hTbui-0007YH-Vo for emacs-devel@gnu.org; Wed, 22 May 2019 20:48:58 -0400 Original-Received: from mail-ed1-x543.google.com ([2a00:1450:4864:20::543]:40545) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hTbui-0007XU-Lw for emacs-devel@gnu.org; Wed, 22 May 2019 20:48:56 -0400 Original-Received: by mail-ed1-x543.google.com with SMTP id j12so6480088eds.7 for ; Wed, 22 May 2019 17:48:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ENPTavP0DScQVfXIEMOE47lzLNG+j6FwkCDV+Dm7ZPQ=; b=jIBlo3GqyPrlmPR3DjWCqf7vFxEDsaBRuXr3xq6nXLMOZP8PNTD7B2DwDd2A8hQM5/ v7qBKXkDooGf4brfRLDKqcNHulBFHW/tmJ8WepFVImZ5iWehNEWF9ywrm2Bgg8gwwDCF EMWOFpKTWss7DmPysP5aHSePlnNf2DexpQ9fX+4j2p0DmQk1cI+7KjpbpYMM8IlY3n2W BrO0twB0zUFfZAuqeC4Xr/oXnOlpU/ROvo5e8cErt+W7ovyXkzyaT2IJsvG6diAmgwho D1b5hxWvzEmQy7JOwENpqFTQKoewgDhm7UeZ1STUwDeUci8kcOcdZCb46BHPaImZAeLK bQug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ENPTavP0DScQVfXIEMOE47lzLNG+j6FwkCDV+Dm7ZPQ=; b=ddXBIAHMwE5YUAKKHqTYFsgw/wSGL2Lqxy8kGHkcEBZPblgn4ApmeGXpPrinUWPt8b migusSvrDEIS6VMxpmoYHLPOtmParHR2wYH+03SvNDm7qsYRUgXA/4J/hA925I00vdt2 R+I0bwmijGA3W4kKxDk5QIe/4nztY7NSyzjeIfD4V3oAKvaIXqdklo0CI9QeGNYX16ND NMdBmcCVd+xERfOYo0l6HEMPMOjMISiCS9VAYLvYI7vYOAIN6oiUDnkMagVOc00pL3qU dSe3WiiVUP/YICNfbJjRjfUaN7HiwEwAFJFrcmky//fsbI9aV0avIbzE5DEIDKV9OQAy acQw== X-Gm-Message-State: APjAAAU4CSsSJms7lHtPsd+ROM6IgnanMjQiDDXJzAODlVmsvUFEIT35 gPqWx0/If2RmRwgvAZEJilkHBw== X-Google-Smtp-Source: APXvYqyS77brLhYPswwXL8iESL7pYmu4RToIOtuQ11+QIl5aTSfIAQu9fbYId0UqibHPrrFPdOUjWg== X-Received: by 2002:a05:6402:1644:: with SMTP id s4mr49499653edx.182.1558572534897; Wed, 22 May 2019 17:48:54 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:8cad:ae29:555d:852d]) by smtp.gmail.com with ESMTPSA id y8sm2390996ejq.24.2019.05.22.17.48.53 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 22 May 2019 17:48:53 -0700 (PDT) In-Reply-To: <874l5uv1oi.fsf@tcd.ie> (Basil L. Contovounesios's message of "Thu, 16 May 2019 16:50:21 +0100") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::543 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236917 Archived-At: "Basil L. Contovounesios" writes: > Stefan Monnier writes: > >>> (defun url-copy-file (url newname &optional ok-if-already-exists >>> - _keep-time _preserve-uid-gid) >>> + _keep-time _preserve-uid-gid _preserve-permissions) >> >> Maybe we should just do >> >> (defun url-copy-file (url newname &optional ok-if-already-exists &rest _) > > I agree. More importantly, an integral ok-if-already-exists should be > handled as in copy-file. How's the following? Added some more function quotes to the patch following an off-list suggestion and pushed to master[1]. [1: 72047556fa]: Fix url-copy-file argument handling 2019-05-23 01:41:00 +0100 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=72047556fa391016ab507c02c2f489c97b53f088 Thanks, -- Basil