* Re: [elpa] main 37f7e91: * elpa-packages: Adapt tramp entry.
[not found] ` <20201222135723.3573020B72@vcs0.savannah.gnu.org>
@ 2020-12-22 16:04 ` Stefan Monnier
2020-12-22 17:48 ` Michael Albinus
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2020-12-22 16:04 UTC (permalink / raw)
To: Michael Albinus; +Cc: emacs-devel
> + ("tramp" :url "git://git.sv.gnu.org/tramp.git"
> + :branch "externals/tramp"
> + :main-file "trampver.el"
> + :make ("autoloads" "info")
> + :doc "tramp.info")
Hmm... admin/README says:
** =:make TARGET=
Indicates that we should run ~make TARGET~ in order to build some files.
This is run before processing =:doc=, so it can be used to generate
the Info and Texinfo file from some other format.
TARGET can also be a list, in which case each target should be
an actual file name (rather than a "phony target").
so it should be either something like:
:make ("tramp-loaddefs.el" "tramp.info")
or something like:
:make "elpa"
BTW, regarding `:doc`, IIUC the difference between `:doc "text/tramp.texi"`
and your makefile rules seems to be mostly `--footnote-style=end`. I'm not
familiar enough with Info and `makeinfo` to know what this does.
Do you think we should maybe use `--footnote-style=end` by default?
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [elpa] main 37f7e91: * elpa-packages: Adapt tramp entry.
2020-12-22 16:04 ` [elpa] main 37f7e91: * elpa-packages: Adapt tramp entry Stefan Monnier
@ 2020-12-22 17:48 ` Michael Albinus
2020-12-22 18:09 ` Stefan Monnier
0 siblings, 1 reply; 4+ messages in thread
From: Michael Albinus @ 2020-12-22 17:48 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> + ("tramp" :url "git://git.sv.gnu.org/tramp.git"
>> + :branch "externals/tramp"
>> + :main-file "trampver.el"
>> + :make ("autoloads" "info")
>> + :doc "tramp.info")
>
> Hmm... admin/README says:
>
> ** =:make TARGET=
> Indicates that we should run ~make TARGET~ in order to build some files.
> This is run before processing =:doc=, so it can be used to generate
> the Info and Texinfo file from some other format.
> TARGET can also be a list, in which case each target should be
> an actual file name (rather than a "phony target").
>
> so it should be either something like:
>
> :make ("tramp-loaddefs.el" "tramp.info")
>
> or something like:
>
> :make "elpa"
What's wrong with my :make ("autoloads" "info")? I haven't seen an error
locally, calling make build/tramp EMACS=...
> Stefan
Best regards, Michael.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [elpa] main 37f7e91: * elpa-packages: Adapt tramp entry.
2020-12-22 17:48 ` Michael Albinus
@ 2020-12-22 18:09 ` Stefan Monnier
2020-12-22 18:23 ` Michael Albinus
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2020-12-22 18:09 UTC (permalink / raw)
To: Michael Albinus; +Cc: emacs-devel
> What's wrong with my :make ("autoloads" "info")? I haven't seen an error
> locally, calling make build/tramp EMACS=...
Other uses (e.g. when you compile the package in-place) expect those to
be real file names.
[ It's also a good practice to use actual file names for make targets
when applicable, BTW. ]
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [elpa] main 37f7e91: * elpa-packages: Adapt tramp entry.
2020-12-22 18:09 ` Stefan Monnier
@ 2020-12-22 18:23 ` Michael Albinus
0 siblings, 0 replies; 4+ messages in thread
From: Michael Albinus @ 2020-12-22 18:23 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> What's wrong with my :make ("autoloads" "info")? I haven't seen an error
>> locally, calling make build/tramp EMACS=...
>
> Other uses (e.g. when you compile the package in-place) expect those to
> be real file names.
Well, the Makefiles are derived from Tramp's master branch. I'd like to
keep them as closed as possible, until there's a need.
> Stefan
Best regards, Michael.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-22 18:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20201222135721.29566.13130@vcs0.savannah.gnu.org>
[not found] ` <20201222135723.3573020B72@vcs0.savannah.gnu.org>
2020-12-22 16:04 ` [elpa] main 37f7e91: * elpa-packages: Adapt tramp entry Stefan Monnier
2020-12-22 17:48 ` Michael Albinus
2020-12-22 18:09 ` Stefan Monnier
2020-12-22 18:23 ` Michael Albinus
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).