From: Robert Pluim <rpluim@gmail.com>
To: Stefan Kangas <stefan@marxist.se>
Cc: emacs-devel@gnu.org
Subject: Re: master 705292c 1/2: Remove unused DEFSYM
Date: Fri, 08 Jan 2021 16:31:23 +0100 [thread overview]
Message-ID: <87im87zbqs.fsf@gmail.com> (raw)
In-Reply-To: <CADwFkm=FixDxtDR40_tCij9QyRcZBbrpHrh0u4dsw4T42jPTHg@mail.gmail.com> (Stefan Kangas's message of "Fri, 8 Jan 2021 08:37:55 -0600")
Stefan Kangas <stefan@marxist.se> writes:
> Robert Pluim <rpluim@gmail.com> writes:
>
>>> branch: master
>>> commit 705292c200a6e35127c26a0ff676f41a072fefa4
>>> Author: Stefan Kangas <stefan@marxist.se>
>>> Commit: Stefan Kangas <stefan@marxist.se>
>>>
>>> Remove unused DEFSYM
>>>
>>> * src/minibuf.c (syms_of_minibuf) <Qhistory_length>: Remove unused
>>> DEFSYM.
>>
>> subr.el:
>>
>> (unless maxelt
>> (setq maxelt (or (get history-var 'history-length)
>> history-length)))
>
> Sorry, I don't follow. Do you see a problem with this commit?
Iʼm just worried that thereʼs code that relies on the history-length
symbol existing (perhaps Iʼm being overly paranoid).
Robert
next prev parent reply other threads:[~2021-01-08 15:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210108135013.27031.26597@vcs0.savannah.gnu.org>
[not found] ` <20210108135015.D842D20DF3@vcs0.savannah.gnu.org>
2021-01-08 14:13 ` master 705292c 1/2: Remove unused DEFSYM Robert Pluim
2021-01-08 14:37 ` Stefan Kangas
2021-01-08 15:31 ` Robert Pluim [this message]
2021-01-08 16:43 ` Stefan Kangas
2021-01-08 18:07 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im87zbqs.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).