From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master 705292c 1/2: Remove unused DEFSYM Date: Fri, 08 Jan 2021 16:31:23 +0100 Message-ID: <87im87zbqs.fsf@gmail.com> References: <20210108135013.27031.26597@vcs0.savannah.gnu.org> <20210108135015.D842D20DF3@vcs0.savannah.gnu.org> <87mtxjzfbw.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7376"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 08 16:32:07 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kxtkF-0001ok-2F for ged-emacs-devel@m.gmane-mx.org; Fri, 08 Jan 2021 16:32:07 +0100 Original-Received: from localhost ([::1]:49306 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kxtkE-0002fB-4A for ged-emacs-devel@m.gmane-mx.org; Fri, 08 Jan 2021 10:32:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46108) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxtjd-0002ES-C5 for emacs-devel@gnu.org; Fri, 08 Jan 2021 10:31:29 -0500 Original-Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]:35271) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kxtjb-00016U-TY for emacs-devel@gnu.org; Fri, 08 Jan 2021 10:31:29 -0500 Original-Received: by mail-wm1-x32c.google.com with SMTP id e25so8786641wme.0 for ; Fri, 08 Jan 2021 07:31:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-followup-to:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=um8V8YFJeBxxXEkR/YGkk2P5wA+QVKu9ojUX1uUi9N4=; b=ViZzjmVgHly4nvGwzKzW6bcEaVFnhPJowhLjAHM5JnWIovmhd9yn0xXKYplN7qZKUU 06Bi2nyLiuXWQMZz/IDR9A5A5kJiS0kUAzwmn+Ci+lFm7yPfizgWPccT3CnqZ8JOSBYr khifjeDvad3uAg3cZ6adt6fc7z5Pta9hbYFLikkVzoedypwor+z/uY10Ui+cS6ocOJNo Ti+L9cXW68VfJndgA4tg3lP6/DqvlN75WMtPmVikW0RaxcWWWmQdAgcHsNNONwBZo0lF rxhuVjWSfckpwgDj8jvM0kXTXrlscteTpBmF52cYO2TItF6dbz5nfihv/bQVvM+lmzBZ euGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-followup-to :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=um8V8YFJeBxxXEkR/YGkk2P5wA+QVKu9ojUX1uUi9N4=; b=g3g4FYJ6PxnqqWtKYyu6RKrthTk90AzHMq/RrfEHq3F0hggzf6uC8tnzbEQ8jO4tH3 53Gza0LclrTW4fxUalqzCKZD9ASpNt7/rgdTZqCpfBDMVhxtv+DjXA2RvW2dmc4w9yki E73i9sh6W7zIA/f96k56POmgGis0Ud9AIQwqhFUjhQzQXfeFXfAd09ga+2X8cBOhysAs 5R7WOP+4bCq9u3Hlhpz7VW1n7KC49dBSGyielSWBq4vBW95LF9KVl2DDe/k0h4tq363l +KxeaSr1I5QK5FVuuj2TXlgHyKYd2DA09ECwnI/MUqBVKa6+bhTQIxZ/VNBJjiy1f82f aHIA== X-Gm-Message-State: AOAM530H9baeDF9J+nYAUissfaeR2LSWLiJrdIcOkK6LQqSdv/Qt/+QJ i4VLs4/89ao7SQOScjbROf0yY3sJoOA= X-Google-Smtp-Source: ABdhPJxiNkmkWiIzbdjKEqjciTji91nTE0xr4kuuwE7rKo5WdYoryVdbgbKLVyTxd2XyEi8/w0Es8w== X-Received: by 2002:a1c:6446:: with SMTP id y67mr3523327wmb.144.1610119885317; Fri, 08 Jan 2021 07:31:25 -0800 (PST) Original-Received: from rltb ([2a01:e34:ecfc:a861:69b6:6aaf:dbd3:8964]) by smtp.gmail.com with ESMTPSA id j13sm11994053wmi.36.2021.01.08.07.31.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 07:31:24 -0800 (PST) Mail-Followup-To: emacs-devel@gnu.org Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: (Stefan Kangas's message of "Fri, 8 Jan 2021 08:37:55 -0600") Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=rpluim@gmail.com; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:262754 Archived-At: Stefan Kangas writes: > Robert Pluim writes: > >>> branch: master >>> commit 705292c200a6e35127c26a0ff676f41a072fefa4 >>> Author: Stefan Kangas >>> Commit: Stefan Kangas >>> >>> Remove unused DEFSYM >>> >>> * src/minibuf.c (syms_of_minibuf) : Remove unused >>> DEFSYM. >> >> subr.el: >> >> (unless maxelt >> (setq maxelt (or (get history-var 'history-length) >> history-length))) > > Sorry, I don't follow. Do you see a problem with this commit? I=CA=BCm just worried that there=CA=BCs code that relies on the history-len= gth symbol existing (perhaps I=CA=BCm being overly paranoid). Robert