From: Vitalie Spinu <spinuvit@gmail.com>
To: emacs-devel@gnu.org
Subject: Completion with (:exclusive 'no) is called twice, and doesn't pass over on sole completion.
Date: Fri, 16 Mar 2012 12:05:14 +0100 [thread overview]
Message-ID: <87haxoyff9.fsf@gmail.com> (raw)
Hi,
The completion in emacs 24 is called twice. For example
(defun foo-completion ()
(when (save-excursion (re-search-backward "\\<\\w*" (point-at-bol) t))
(let ((token (match-string-no-properties 0))
(beg (match-beginning 0))
(end (match-end 0)))
(message "%s:" token)
(when (= end (point))
(list beg end (list "aaaa" "aaaaaaa" "bbbb" "truncat") :exclusive 'no)))))
(add-to-list 'completion-at-point-functions 'foo-completion)
;; it is now (foo-completion lisp-completion-at-point t)
Place your point at the end of 'aaaa and you try to complete. I am
getting
aaa:
aaaa:
in my message buffer. Which means the completion is called twice. I hope
this is not an intended behavior, as it might seriously interfere with
custom completion. For example I might want to have a different behavior
on the second consequent invocation of the completion (give a message,
modify the candidates etc).
Second problem is that if the completion is sole, the handling is not
passed over. For example after 'truncat I am getting a message "Sole
completion" and the lisp-completion-at-point is not reached at all. I
believe it's not how it should work.
In all the rest, new completion system is virtually perfect, thanks.
Vitalie.
next reply other threads:[~2012-03-16 11:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 11:05 Vitalie Spinu [this message]
2012-03-16 12:18 ` Completion with (:exclusive 'no) is called twice, and doesn't pass over on sole completion Vitalie Spinu
2012-03-16 17:20 ` Stefan Monnier
2012-03-16 19:33 ` Vitalie Spinu
2012-03-17 22:34 ` Stefan Monnier
2012-03-17 22:43 ` Lennart Borgman
2012-03-17 23:33 ` Vitalie Spinu
2012-03-18 2:03 ` Stefan Monnier
2012-03-18 9:35 ` Vitalie Spinu
2012-03-18 15:42 ` Stefan Monnier
2012-03-18 19:18 ` Vitalie Spinu
2012-03-19 0:53 ` Stefan Monnier
2012-03-19 8:35 ` Vitalie Spinu
2012-03-19 12:49 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87haxoyff9.fsf@gmail.com \
--to=spinuvit@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).