unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Vitalie Spinu <spinuvit@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Completion with (:exclusive 'no) is called twice, and doesn't pass over on sole completion.
Date: Sun, 18 Mar 2012 00:33:44 +0100	[thread overview]
Message-ID: <87haxmx0o7.fsf@gmail.com> (raw)
In-Reply-To: <jwvlimyvpbz.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sat, 17 Mar 2012 18:34:31 -0400")

>>>> Stefan Monnier <monnier@iro.umontreal.ca>
>>>> on Sat, 17 Mar 2012 18:34:31 -0400 wrote:

  >> Please see my other message with a more serious related issue.
  >> It might give some clues.

  > I do not see your other message.  Is it on emacs-devel or a bug-report?

Yes to emacs-devel,
http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00249.html

  >> In my case it's meaningful, as I retrieve completions from a
  >> process.

  > Then you should probably get your completions from the completion-table,
  > rather than from completion-at-point-functions.
  > IOW your completion-at-point-functions should return (without contacting
  > any process, other than maybe checking whether a process exists)
  > a completion table that's a function, e.g. built with
  > completion-table-dynamic, or using complete-with-action and it's *that*
  > function which contacts the process.

Thanks for the pointer. I was not aware of this distinction. But why
would that make a difference? Isn't the end result the same? Info is
silent on this.

  >> Also I think, popup functions should use a different list (like
  >> completion-popup-functions).

  > That might be right (tho I hope it's not), but it doesn't eliminate the
  > fact that completion-at-point-functions might be called in
  > various circumstances.

I've written auto-complete support and emacs-24 completion at point for
R. And it turned out that these two are really distinct features. One is
fast, cache based and sloppy, as it should not interfere with the
editing. Another one is exact and might be very slow, because it
contacts the associated process. The TAB completions can afford to be
slow, as there is no editing.

  >> As users might want to use different sets of completions.

  > I expect completion-at-point-functions to be setup by major modes rather
  > than by users.

Take auto-complete as an example. There are plenty of different
ac-sources, and users use whatever completion they want.

Related topic.  It would be great to have a separate "namespace" for all
buildin completions, or even a dedicated package. Then users and
developers can easily find buildin stuff.

For instance `completion-filename' instead of `comint-filename-completion',
 `completion-etags' instead of `tags-completion-at-point-function'
etc. Auto-complete package is a good example here - all sources start
with "ac-source-".

  >> Also popup completions *must* be considerably less computationally
  >> intensive, so it's probably a different set of functions anyhow.

  > The way I see it, completion-at-point-functions would instead include in
  > the `props' it returns, enough info to determine whether to use that
  > completion data for popup completion.

To return the props it still must be called, right? Indeed if the
completion function were aware that it was called from popup, then it
can simply return nil to be skipped. But, AFAICT, this is not currently
the case.

Vitalie.



  parent reply	other threads:[~2012-03-17 23:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-16 11:05 Completion with (:exclusive 'no) is called twice, and doesn't pass over on sole completion Vitalie Spinu
2012-03-16 12:18 ` Vitalie Spinu
2012-03-16 17:20 ` Stefan Monnier
2012-03-16 19:33   ` Vitalie Spinu
2012-03-17 22:34     ` Stefan Monnier
2012-03-17 22:43       ` Lennart Borgman
2012-03-17 23:33       ` Vitalie Spinu [this message]
2012-03-18  2:03         ` Stefan Monnier
2012-03-18  9:35           ` Vitalie Spinu
2012-03-18 15:42             ` Stefan Monnier
2012-03-18 19:18               ` Vitalie Spinu
2012-03-19  0:53                 ` Stefan Monnier
2012-03-19  8:35                   ` Vitalie Spinu
2012-03-19 12:49                     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87haxmx0o7.fsf@gmail.com \
    --to=spinuvit@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).